Re: [PATCH iperf3 v3] add MPTCPv1 support

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 12/03/2024 08:27, Geliang Tang wrote:
> Hi Matt,
> 
> On Tue, Mar 12, 2024 at 08:10:28AM +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> 11 Mar 2024 08:04:05 Geliang Tang <geliang@kernel.org>:
>>
>>> The Multipath TCP (MPTCP) protocol (v1 / RFC 8684) has been added in
>>> the upstream Linux kernel since v5.6.
>>>
>>> MPTCP is strongly tied to TCP, and the kernel APIs are almost the same.
>>> The only required dependency is the 'IPPROTO_MPTCP' protocol number
>>> definition, which should be provided by the netinet/in.h header if it
>>> is recent enough.
>>>
>>> This patch adds a new flag '-m' or '--multipath' to support MPTCPv1.
>>
>> I just noticed you switched back to "multipath" instead of "mptcp".
>> I think it is best to stick with "mptcp", because "multipath"
>> is too vague, thus confusing: it could be multipath as in multiple
>> flows, multicast, with other protocols like UDP, etc.
>>
>> Best to use "mptcp" everywhere: variables, strings, description, etc.
> 
> Sure, I'll send a v4 to update the flag to '--mptcp'.

Thanks!

> But I don't know
> how to update the pull request on github. Should I send another pull
> request?

No, please don't open a new pull request, nor close the old one, simply
override your remote branch on GitHub (`git push --force`).

>>> It can be used like this:>>>
>>>> iperf3 -m -s
>>>> iperf3 -m -c 127.0.0.1
>>
>> If the server doesn't have "-m", only the client, does it use MPTCP?
> 
> Yes, it use MPTCP in this case. I just tested it.

Great, thank you for having tested that!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.