From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Michal Luczaj <mhal@rbox.co>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Jiri Olsa <jolsa@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Shuah Khan <shuah@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Eric Dumazet <edumazet@kernel.org>,
Kuniyuki Iwashima <kuniyu@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Stanislav Fomichev <sdf@fomichev.me>
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH bpf-next v3 2/8] bpf, sockmap: Restrict iter-context sockmap updates to iter/sockmap
Date: Mon, 9 Nov 2026 10:15:21 +0800 [thread overview]
Message-ID: <47eae9bc-6d8b-4b73-8fe7-869753ef9600@linux.dev> (raw)
In-Reply-To: <20261107-sockmap-update-limit-iter-v3-2-7c0bad1ad036@rbox.co>
On 11/8/26 1:58 AM, Michal Luczaj wrote:
> Among tracing progs, allow only iter/sockmap to update sockmaps and
> sockhashes. Previously, any BPF_TRACE_ITER program could perform these
> updates, which caused locking issues in specific scenarios [1][2][3]. This
> tightening is part of the broader effort to lock down the BPF API [4].
>
> [1]: commit 4d328dd69538 ("bpf, sockmap: Fix af_unix iter deadlock")
> [2]: commit 64c2f93fc325 ("bpf, sockmap: Take state lock for af_unix iter")
> [3]: https://msgid.link/87echn2fhd.fsf@cloudflare.com
> [4]: https://msgid.link/akRZ_e7DJh2aP-2i@john-p8
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://msgid.link/20260626205814.BAC3C1F000E9@smtp.kernel.org
> Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>
next prev parent reply other threads:[~2026-11-09 2:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 17:58 [PATCH bpf-next v3 0/8] bpf, sockmap: Restrict iter-context sockmap updates to sockmap iterators Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 1/8] selftests/bpf: Remove sockmap update from bpf_iter_unix Michal Luczaj
2026-11-09 2:14 ` Jiayuan Chen
2026-11-07 17:58 ` [PATCH bpf-next v3 2/8] bpf, sockmap: Restrict iter-context sockmap updates to iter/sockmap Michal Luczaj
2026-11-09 2:15 ` Jiayuan Chen [this message]
2026-11-07 17:58 ` [PATCH bpf-next v3 3/8] selftests/bpf: Add negative test for sockmap update from non-sockmap iter Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 4/8] bpf, docs: Document BPF_ITER_NOSLEEP Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 5/8] bpf: Restrict bpf_sock_destroy() to iter/{tcp,udp} Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 6/8] bpf: Mark bpf_iter__sockmap::sk as PTR_TRUSTED Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 7/8] selftests/bpf: Add iter/sockmap bpf_sock_destroy() negative test Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 8/8] bpf: Fix "unresolved symbol tcp_request_sock" build error Michal Luczaj
2026-11-07 18:14 ` sashiko-bot
2026-11-07 21:39 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47eae9bc-6d8b-4b73-8fe7-869753ef9600@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@kernel.org \
--cc=emil@etsalapatis.com \
--cc=horms@kernel.org \
--cc=ihor.solodrai@linux.dev \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=sashiko-bot@kernel.org \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.