From: sashiko-bot@kernel.org
To: "Michal Luczaj" <mhal@rbox.co>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 8/8] bpf: Fix "unresolved symbol tcp_request_sock" build error
Date: Sat, 07 Nov 2026 18:14:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-203160@kernel.org> (raw)
In-Reply-To: <20261107-sockmap-update-limit-iter-v3-8-7c0bad1ad036@rbox.co>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bpf: missing Fixes: trailer for tcp_request_sock BTF build fix
--
commit 96ec9bcc071c52f5537149bdc9a41b81773ef3e6
Author: Michal Luczaj <mhal@rbox.co>
> bpf: Fix "unresolved symbol tcp_request_sock" build error
>
> CONFIG_WERROR=y CONFIG_NET=y CONFIG_INET=n build fails:
>
> WARN: resolve_btfids: unresolved symbol tcp_request_sock
> Failed to generate BTF for vmlinux
> Try to disable CONFIG_DEBUG_INFO_BTF
> make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
> make[1]: *** [.../Makefile:1379: vmlinux] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
>
> Handle it in the style of commit d82a532a6115 ("bpf: Fix "unresolved
> symbol" build error with resolve_btfids"): force BTF generation.
>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
[Severity: Low]
Commit fce557bcef11 ("bpf: Make btf_sock_ids global") exposed btf_sock_ids
to resolve_btfids under CONFIG_NET=y, and commit a90765c6f603 ("tcp: move
reqsk_fastopen_remove to net/ipv4/tcp_fastopen.c") moved the last
CONFIG_NET=y user of struct tcp_request_sock into a file built only under
CONFIG_INET=y.
Should this include a Fixes: tag?
Fixes: a90765c6f603 ("tcp: move reqsk_fastopen_remove to net/ipv4/tcp_fastopen.c")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261107-sockmap-update-limit-iter-v3-0-7c0bad1ad036@rbox.co?part=8
next prev parent reply other threads:[~2026-11-07 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 17:58 [PATCH bpf-next v3 0/8] bpf, sockmap: Restrict iter-context sockmap updates to sockmap iterators Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 1/8] selftests/bpf: Remove sockmap update from bpf_iter_unix Michal Luczaj
2026-11-09 2:14 ` Jiayuan Chen
2026-11-07 17:58 ` [PATCH bpf-next v3 2/8] bpf, sockmap: Restrict iter-context sockmap updates to iter/sockmap Michal Luczaj
2026-11-09 2:15 ` Jiayuan Chen
2026-11-07 17:58 ` [PATCH bpf-next v3 3/8] selftests/bpf: Add negative test for sockmap update from non-sockmap iter Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 4/8] bpf, docs: Document BPF_ITER_NOSLEEP Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 5/8] bpf: Restrict bpf_sock_destroy() to iter/{tcp,udp} Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 6/8] bpf: Mark bpf_iter__sockmap::sk as PTR_TRUSTED Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 7/8] selftests/bpf: Add iter/sockmap bpf_sock_destroy() negative test Michal Luczaj
2026-11-07 17:58 ` [PATCH bpf-next v3 8/8] bpf: Fix "unresolved symbol tcp_request_sock" build error Michal Luczaj
2026-11-07 18:14 ` sashiko-bot [this message]
2026-11-07 21:39 ` Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-203160@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=mhal@rbox.co \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.