Re: [PATCH] [ETHTOOL]: Add support for large eeproms

[Jeff Garzik <jeff@garzik.org>]

Mandeep Singh Baines wrote:
> Joe Perches (joe@perches.com) wrote:
>> This looks better.
>> There's a typo at line 315 though, it needs a ";".
>>
> 
> Oops. In my haste to get out the revised patch I didn't bother to test.
> Bad Mandeep.
> 
>> I was also wrong that int ret _does_ need to be
>> initialized to 0 in case (eeprom.len == 0)
>>
> 
> I knew I had that there for a reason. But I forgot to initialize ret in
> ethtool_get_eeprom. You've fixed this in your update to the patch:)
> 
>> I think this should be written as below:
>>
> 
> Agreed. You've fixed my bugs and I think setting ret inside the if
> makes the code easier to reason about.
> 
> I've tested your updated version of the patch and it looks good.
> 
>> cheers, Joe
>>
>>  net/core/ethtool.c |   68 +++++++++++++++++++++++++++++-----------------------
>>  1 files changed, 38 insertions(+), 30 deletions(-)

someone wanna resend with proper sign-offs?