From: "H. Peter Anvin" <hpa@zytor.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Erik Bosman <ebn310@few.vu.nl>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrea Arcangeli <andrea@cpushare.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC
Date: Sat, 12 Apr 2008 13:48:02 -0700 [thread overview]
Message-ID: <48012002.8030701@zytor.com> (raw)
In-Reply-To: <20080412124947.146865e4@laptopd505.fenrus.org>
Arjan van de Ven wrote:
>
> Hi,
>
> why did you make this a configuration option? In general it's not
> a good idea to make userspace visible ABI's (PR_* clearly is one of these)
> a CONFIG option unless there's some HUGE space saving going on.
> I don't see that here....
>
> So can you explain your rationale for making this a config option?
>
I also saw no mention about performance impact, which need to be
considered whenever *anything* is proposed to be inserted into a hot
path. It may be (heck, *should be*) that the performance impact isn't
measurable, but that needs to be positively established.
-hpa
next prev parent reply other threads:[~2008-04-12 20:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 16:55 [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC Erik Bosman
2008-04-12 19:49 ` Arjan van de Ven
2008-04-12 20:48 ` H. Peter Anvin [this message]
2008-04-12 21:05 ` Erik Bosman
2008-04-12 21:12 ` Arjan van de Ven
2008-04-13 21:51 ` Erik Bosman
2008-04-13 22:02 ` H. Peter Anvin
2008-04-14 8:42 ` Ingo Molnar
2008-04-13 22:24 ` [PATCH 2/3-REVISED] " Erik Bosman
2008-04-14 3:58 ` Arjan van de Ven
2008-04-14 8:48 ` Ingo Molnar
2008-04-14 10:57 ` [PATCH 2/3] " Michael Kerrisk
2008-04-14 11:59 ` Erik Bosman
2008-04-14 12:21 ` Michael Kerrisk
2008-04-26 22:47 ` dean gaudet
2008-04-26 22:51 ` H. Peter Anvin
2008-04-26 23:14 ` dean gaudet
2008-04-26 23:46 ` H. Peter Anvin
2008-04-27 0:29 ` dean gaudet
2008-04-27 0:37 ` H. Peter Anvin
2008-04-27 0:47 ` David Miller
2008-04-15 7:29 ` Andrew Morton
2008-04-15 7:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48012002.8030701@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@cpushare.com \
--cc=arjan@infradead.org \
--cc=ebn310@few.vu.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.