From: "H. Peter Anvin" <hpa@zytor.com>
To: dean gaudet <dean@arctic.org>
Cc: Erik Bosman <ejbosman@cs.vu.nl>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrea Arcangeli <andrea@cpushare.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC
Date: Sat, 26 Apr 2008 16:46:29 -0700 [thread overview]
Message-ID: <4813BED5.7070000@zytor.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0804261612430.6108@twinlark.arctic.org>
dean gaudet wrote:
> On Sat, 26 Apr 2008, H. Peter Anvin wrote:
>
>> dean gaudet wrote:
>>> i might be too late... but shouldn't these #defines be PR_SET_RDTSC and
>>> PR_GET_RDTSC or something like that?
>>>
>>> to me calling them PR_SET_TSC/PR_GET_TSC just seem like alternative ways to
>>> change/get the TSC (and could even reduce to portable TSC implementations...
>>> since such registers do exist on other architectures).
>>>
>> I would argue no, the flag is "is the TSC available". RDTSC is an
>> x86-specific name and would map poorly onto other architectures.
>
> yeah but "SET TSC" to me reads as "set the TSC".... i read nothing about
> making some instruction available or not.
>
> although clock_gettime/clock_settime could more natural APIs for such
> things.
>
PR_SET/PR_GET are the common prefixes, though.
-hpa
next prev parent reply other threads:[~2008-04-26 23:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 16:55 [PATCH 2/3] x86: Implement prctl PR_GET_TSC and PR_SET_TSC Erik Bosman
2008-04-12 19:49 ` Arjan van de Ven
2008-04-12 20:48 ` H. Peter Anvin
2008-04-12 21:05 ` Erik Bosman
2008-04-12 21:12 ` Arjan van de Ven
2008-04-13 21:51 ` Erik Bosman
2008-04-13 22:02 ` H. Peter Anvin
2008-04-14 8:42 ` Ingo Molnar
2008-04-13 22:24 ` [PATCH 2/3-REVISED] " Erik Bosman
2008-04-14 3:58 ` Arjan van de Ven
2008-04-14 8:48 ` Ingo Molnar
2008-04-14 10:57 ` [PATCH 2/3] " Michael Kerrisk
2008-04-14 11:59 ` Erik Bosman
2008-04-14 12:21 ` Michael Kerrisk
2008-04-26 22:47 ` dean gaudet
2008-04-26 22:51 ` H. Peter Anvin
2008-04-26 23:14 ` dean gaudet
2008-04-26 23:46 ` H. Peter Anvin [this message]
2008-04-27 0:29 ` dean gaudet
2008-04-27 0:37 ` H. Peter Anvin
2008-04-27 0:47 ` David Miller
2008-04-15 7:29 ` Andrew Morton
2008-04-15 7:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4813BED5.7070000@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=andrea@cpushare.com \
--cc=arjan@infradead.org \
--cc=dean@arctic.org \
--cc=ejbosman@cs.vu.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.