From: Timur Tabi <timur@freescale.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
York Sun <yorksun@freescale.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU
Date: Mon, 14 Apr 2008 09:12:25 -0500 [thread overview]
Message-ID: <48036649.6000409@freescale.com> (raw)
In-Reply-To: <4803620C.6020905@gmail.com>
Jiri Slaby wrote:
> On 04/14/2008 03:45 PM, Timur Tabi wrote:
>> Jiri Slaby wrote:
>>
>>> See
>>> http://lkml.org/lkml/2008/3/12/375
>> That email is dated 3/12 and those comments are about v1 of the patch. The most
>> recent posted version is v5 and it addresses all these issues. See
>> http://lkml.org/lkml/2008/4/1/346
>
> Ok, how is the sleep-inside-spinlock in fsl_diu_open resolved? rh_alloc might
> sleep if I still see correctly, do I?
Hmmm... I thought I had an answer to this question, but I checked the patch
again, and it looks like this particular issue hasn't been fixed. rh_alloc can
still sleep. I know we worked on fixing this bug, so I'm not sure why it's
still there.
However, we don't need to call rh_alloc(). The arch/powerpc code has been
updated to remove the need for us to a use an rheap.
Unfortunately, the author of the patch, York, is out this week, so I'll have to
take care of this. It'd be easier to modify rh_alloc() so that it doesn't
sleep, so that's what I'm going to do.
--
Timur Tabi
Linux kernel developer at Freescale
WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@freescale.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
York Sun <yorksun@freescale.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
galak@kernel.crashing.org
Subject: Re: [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU
Date: Mon, 14 Apr 2008 09:12:25 -0500 [thread overview]
Message-ID: <48036649.6000409@freescale.com> (raw)
In-Reply-To: <4803620C.6020905@gmail.com>
Jiri Slaby wrote:
> On 04/14/2008 03:45 PM, Timur Tabi wrote:
>> Jiri Slaby wrote:
>>
>>> See
>>> http://lkml.org/lkml/2008/3/12/375
>> That email is dated 3/12 and those comments are about v1 of the patch. The most
>> recent posted version is v5 and it addresses all these issues. See
>> http://lkml.org/lkml/2008/4/1/346
>
> Ok, how is the sleep-inside-spinlock in fsl_diu_open resolved? rh_alloc might
> sleep if I still see correctly, do I?
Hmmm... I thought I had an answer to this question, but I checked the patch
again, and it looks like this particular issue hasn't been fixed. rh_alloc can
still sleep. I know we worked on fixing this bug, so I'm not sure why it's
still there.
However, we don't need to call rh_alloc(). The arch/powerpc code has been
updated to remove the need for us to a use an rheap.
Unfortunately, the author of the patch, York, is out this week, so I'll have to
take care of this. It'd be easier to modify rh_alloc() so that it doesn't
sleep, so that's what I'm going to do.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2008-04-14 14:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-12 21:43 Driver for Freescale Display Interface Unit (A LCD controller) York Sun
2008-03-12 21:43 ` York Sun
2008-03-12 21:43 ` [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU York Sun
2008-03-12 21:43 ` York Sun
2008-03-12 21:43 ` [PATCH 2/2] Add DIU platform code for MPC8610HPCD York Sun
2008-03-12 21:43 ` York Sun
2008-04-14 14:18 ` Arnd Bergmann
2008-03-12 22:20 ` [PATCH 1/2] Driver for Freescale 8610 and 5121 DIU Jiri Slaby
2008-03-12 22:20 ` Jiri Slaby
2008-04-11 21:45 ` Jiri Slaby
2008-04-11 21:45 ` Jiri Slaby
2008-04-12 5:18 ` Andrew Morton
2008-04-12 5:18 ` Andrew Morton
2008-04-14 13:39 ` Timur Tabi
2008-04-14 13:39 ` Timur Tabi
2008-04-14 13:43 ` Jiri Slaby
2008-04-14 13:43 ` Jiri Slaby
2008-04-14 13:45 ` Timur Tabi
2008-04-14 13:45 ` Timur Tabi
2008-04-14 13:54 ` Jiri Slaby
2008-04-14 13:54 ` Jiri Slaby
2008-04-14 14:12 ` Timur Tabi [this message]
2008-04-14 14:12 ` Timur Tabi
2008-04-14 14:24 ` Jiri Slaby
2008-04-14 14:24 ` Jiri Slaby
2008-04-14 14:49 ` Timur Tabi
2008-04-14 15:43 ` Jiri Slaby
2008-04-14 15:46 ` Timur Tabi
2008-04-14 19:03 ` Andrew Morton
2008-04-14 19:03 ` Andrew Morton
2008-03-13 0:10 ` Stephen Rothwell
2008-03-13 0:10 ` Stephen Rothwell
2008-03-13 10:17 ` Driver for Freescale Display Interface Unit (A LCD controller) Geert Uytterhoeven
2008-03-13 10:17 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48036649.6000409@freescale.com \
--to=timur@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.