From: Li Zefan <lizf@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"xemul@openvz.org" <xemul@openvz.org>,
menage@google.com, "linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] use vmalloc for mem_cgroup allocation. v2
Date: Tue, 15 Apr 2008 11:14:24 +0800 [thread overview]
Message-ID: <48041D90.2040702@cn.fujitsu.com> (raw)
In-Reply-To: <20080415121617.16127623.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Mon, 14 Apr 2008 19:17:30 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>> Well... vmalloced memory is of course a little slower to use - additional
>> TLB pressure.
>>
>> Do you think the memcgroup is accessed frequently enough to use vmalloc()
>> only on those architectures which actually need it?
>>
>> Because it'd be pretty simple to implement:
>>
>> if (sizeof(struct mem_group) > PAGE_SIZE)
>> vmalloc()
>> else
>> kmalloc()
>>
>> ...
>>
>> if (sizeof(struct mem_group) > PAGE_SIZE)
>> vfree()
>> else
>> kfree()
>>
>> the compiler will optimise away the `if'.
>>
>
> Hmm, ok. I'll rewrite one to do that.
>
It will be better to use wrappers for these: mem_cgroup_alloc() and mem_cgroup_free()
> Thanks,
> -Kame
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"xemul@openvz.org" <xemul@openvz.org>,
menage@google.com, "linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] use vmalloc for mem_cgroup allocation. v2
Date: Tue, 15 Apr 2008 11:14:24 +0800 [thread overview]
Message-ID: <48041D90.2040702@cn.fujitsu.com> (raw)
In-Reply-To: <20080415121617.16127623.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Mon, 14 Apr 2008 19:17:30 -0700
> Andrew Morton <akpm@linux-foundation.org> wrote:
>> Well... vmalloced memory is of course a little slower to use - additional
>> TLB pressure.
>>
>> Do you think the memcgroup is accessed frequently enough to use vmalloc()
>> only on those architectures which actually need it?
>>
>> Because it'd be pretty simple to implement:
>>
>> if (sizeof(struct mem_group) > PAGE_SIZE)
>> vmalloc()
>> else
>> kmalloc()
>>
>> ...
>>
>> if (sizeof(struct mem_group) > PAGE_SIZE)
>> vfree()
>> else
>> kfree()
>>
>> the compiler will optimise away the `if'.
>>
>
> Hmm, ok. I'll rewrite one to do that.
>
It will be better to use wrappers for these: mem_cgroup_alloc() and mem_cgroup_free()
> Thanks,
> -Kame
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-04-15 3:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 1:54 [PATCH] use vmalloc for mem_cgroup allocation KAMEZAWA Hiroyuki
2008-04-15 1:54 ` KAMEZAWA Hiroyuki
2008-04-15 1:57 ` Li Zefan
2008-04-15 1:57 ` Li Zefan
2008-04-15 2:07 ` KAMEZAWA Hiroyuki
2008-04-15 2:07 ` KAMEZAWA Hiroyuki
2008-04-15 2:10 ` [PATCH] use vmalloc for mem_cgroup allocation. v2 KAMEZAWA Hiroyuki
2008-04-15 2:10 ` KAMEZAWA Hiroyuki
2008-04-15 2:08 ` Li Zefan
2008-04-15 2:08 ` Li Zefan
2008-04-15 2:20 ` Andrew Morton
2008-04-15 2:20 ` Andrew Morton
2008-04-15 2:28 ` Harvey Harrison
2008-04-15 2:28 ` Harvey Harrison
2008-04-15 3:12 ` KAMEZAWA Hiroyuki
2008-04-15 3:12 ` KAMEZAWA Hiroyuki
2008-04-15 2:17 ` Andrew Morton
2008-04-15 2:17 ` Andrew Morton
2008-04-15 3:16 ` KAMEZAWA Hiroyuki
2008-04-15 3:16 ` KAMEZAWA Hiroyuki
2008-04-15 3:14 ` Li Zefan [this message]
2008-04-15 3:14 ` Li Zefan
2008-04-15 3:22 ` KAMEZAWA Hiroyuki
2008-04-15 3:22 ` KAMEZAWA Hiroyuki
2008-04-15 5:12 ` [PATCH] use vmalloc for mem_cgroup allocation. v3 KAMEZAWA Hiroyuki
2008-04-15 5:12 ` KAMEZAWA Hiroyuki
2008-04-16 19:19 ` [PATCH] use vmalloc for mem_cgroup allocation Christoph Lameter
2008-04-16 19:19 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48041D90.2040702@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.