From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] phy: sun4i: add support for A64 usb phy
Date: Sun, 31 Jul 2016 21:18:12 +0800 [thread overview]
Message-ID: <48051469971092@web25g.yandex.ru> (raw)
In-Reply-To: <CABHD4K9awH3moyCktEq3acYN=GS74nhThuFDsYt10UTqOHSw3Q@mail.gmail.com>
31.07.2016, 20:39, "Amit Tomer" <amittomer25@gmail.com>:
> Hello ,
>
>> ?@@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
>> ?????????????????val = readl(phy->pmu + REG_PMU_UNK_H3);
>> ?????????????????writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
>> ?????????} else {
>> ?+ /* A64 needs also this unknown bit */
>> ?+ if (data->cfg->type == sun50i_a64_phy) {
>> ?+ val = readl(phy->pmu + REG_PMU_UNK_H3);
>> ?+ writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
>> ?+ }
>> ?+
>
> This bit is also set for H3, shall we reuse it or we should enclose it
> in else-if part ?
To be honest, I don't know which format is better...
I'm not so familiar about the tradition of Linux kernel coding style...
>
> Thanks
> Amit.
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.xyz>
To: Amit Tomer <amittomer25@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Reinder de Haan <patchesrdh@mveas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Tony Prisk <linux@prisktech.co.nz>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy
Date: Sun, 31 Jul 2016 21:18:12 +0800 [thread overview]
Message-ID: <48051469971092@web25g.yandex.ru> (raw)
In-Reply-To: <CABHD4K9awH3moyCktEq3acYN=GS74nhThuFDsYt10UTqOHSw3Q@mail.gmail.com>
31.07.2016, 20:39, "Amit Tomer" <amittomer25@gmail.com>:
> Hello ,
>
>> @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
>> val = readl(phy->pmu + REG_PMU_UNK_H3);
>> writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
>> } else {
>> + /* A64 needs also this unknown bit */
>> + if (data->cfg->type == sun50i_a64_phy) {
>> + val = readl(phy->pmu + REG_PMU_UNK_H3);
>> + writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
>> + }
>> +
>
> This bit is also set for H3, shall we reuse it or we should enclose it
> in else-if part ?
To be honest, I don't know which format is better...
I'm not so familiar about the tradition of Linux kernel coding style...
>
> Thanks
> Amit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-07-31 13:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 11:25 [PATCH 1/3] dt: bindings: add bindings for Allwinner A64 usb phy Icenowy Zheng
2016-07-31 11:25 ` Icenowy Zheng
2016-07-31 11:25 ` [PATCH 2/3] phy: sun4i: add support for " Icenowy Zheng
2016-07-31 11:25 ` Icenowy Zheng
2016-07-31 12:39 ` Amit Tomer
2016-07-31 12:39 ` Amit Tomer
2016-07-31 12:39 ` Amit Tomer
2016-07-31 13:18 ` Icenowy Zheng [this message]
2016-07-31 13:18 ` Icenowy Zheng
2016-07-31 13:18 ` Icenowy Zheng
2016-07-31 13:18 ` Icenowy Zheng
2016-07-31 14:39 ` Hans de Goede
2016-07-31 14:39 ` Hans de Goede
2016-07-31 14:39 ` Hans de Goede
2016-07-31 14:50 ` Chen-Yu Tsai
2016-07-31 14:50 ` Chen-Yu Tsai
2016-07-31 14:50 ` Chen-Yu Tsai
2016-07-31 15:24 ` Hans de Goede
2016-07-31 15:24 ` Hans de Goede
2016-07-31 15:24 ` Hans de Goede
2016-07-31 11:25 ` [PATCH 3/3] ehci-platform: add the max clock number to 4 Icenowy Zheng
2016-07-31 11:25 ` Icenowy Zheng
2016-08-01 6:58 ` Arnd Bergmann
2016-08-01 6:58 ` Arnd Bergmann
2016-08-01 6:58 ` Arnd Bergmann
2016-08-01 7:05 ` Icenowy Zheng
2016-08-01 7:05 ` Icenowy Zheng
2016-08-01 7:27 ` Hans de Goede
2016-08-01 7:27 ` Hans de Goede
2016-08-01 7:27 ` Hans de Goede
2016-08-01 8:18 ` Icenowy Zheng
2016-08-01 8:18 ` Icenowy Zheng
2016-08-01 9:49 ` Hans de Goede
2016-08-01 9:49 ` Hans de Goede
2016-08-01 9:49 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48051469971092@web25g.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.