All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Alexey Starikovskiy <aystarik@gmail.com>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH 65/73] ACPICA: Fix for extraneous debug message for packages
Date: Wed, 16 Apr 2008 01:51:26 +0400	[thread overview]
Message-ID: <4805235E.6090708@suse.de> (raw)
In-Reply-To: <9D39833986E69849A2A8E74C1078B6B32A4E98@orsmsx415.amr.corp.intel.com>

Moore, Robert wrote:
> Well, yes native word size being the pointer size, now that the 16-bit
> model is out of the picture.
> 
> We defined ACPI_NATIVE_UINT in order to have an integer data type that
> is 32 bits in 32-bit mode, and 64 bits in 64-bit mode (and originally,
> 16 bits in 16-bit mode). There is no corresponding C type that can
> accomplish this across all compilation models.
> 
> Yes, ACPI_NATIVE_UINT has issues with printf because there is
> unfortunately no printf formatting operator other than %p that goes 32
> bits in 32-bit mode and 64 bits in 64-bit mode. I think there may be
> cases in ACPICA where we just cast an ACPI_NATIVE_UINT to a pointer to
> use it with printf.
Ok, let it be obscure type with such properties.
Now back to original patch, where we change from "acpi_native_uint i;" to
"uint32 i;" Both types are not supported by printf(), while the reason of 
the patch to gain such support. There is no expectation that i will need to
be 32 bits long to not roll over, let along 64 bit.
So, once again, why we used acpi_native_uint there and why we changed that 
to uint32 and not unsigned?

Regards,
Alex.


  reply	other threads:[~2008-04-15 21:51 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12  4:24 ACPICA branch Len Brown
2008-04-12  4:24 ` [PATCH 01/73] ACPICA: Several fixes for internal method result stack Len Brown
2008-04-12  4:24   ` [PATCH 02/73] ACPICA: Removed unused code Len Brown
2008-04-12  4:24   ` [PATCH 03/73] ACPICA: Update for mutiple global lock acquisitions by same thread Len Brown
2008-04-12  4:24   ` [PATCH 04/73] ACPICA: changed order of interpretation of operand objects Len Brown
2008-04-12  4:24   ` [PATCH 05/73] ACPICA: Avoid use of invalid pointers in returned object field Len Brown
2008-04-12  4:24   ` [PATCH 06/73] ACPICA: Fixed a couple compiler warnings for extra extern statements Len Brown
2008-04-12  4:24   ` [PATCH 07/73] ACPICA: Update comments for acquire/release mutex interfaces Len Brown
2008-04-12  4:24   ` [PATCH 08/73] ACPICA: Removed extraneous code Len Brown
2008-04-12  4:24   ` [PATCH 09/73] ACPICA: Removed obsolete ACPI_NO_INTEGER64_SUPPORT define Len Brown
2008-04-12  4:24   ` [PATCH 10/73] ACPICA: Misc fixes for recent global lock code update Len Brown
2008-04-12  4:24   ` [PATCH 11/73] ACPICA: Increase maximum buffer size dumped to screen in buffer object dump Len Brown
2008-04-12  4:24   ` [PATCH 12/73] ACPICA: Fix for package reference counts Len Brown
2008-04-12  4:24   ` [PATCH 13/73] ACPICA: Update version to 20070320 Len Brown
2008-04-12  4:24   ` [PATCH 14/73] ACPICA: Fix for update of the Global Lock Handle Len Brown
2008-04-12  4:24   ` [PATCH 15/73] ACPICA: Update version to 20070508 Len Brown
2008-04-12  4:24   ` [PATCH 16/73] ACPICA: Updated error message for dynamic method serialization Len Brown
2008-04-12  4:25   ` [PATCH 17/73] ACPICA: Support for iASL - multiple files and wildcards Len Brown
2008-04-12  4:25   ` [PATCH 18/73] ACPICA: Add minimal disassembly support for the SLIC table Len Brown
2008-04-12  4:25   ` [PATCH 19/73] ACPICA: New interfaces for table event handlers Len Brown
2008-04-12  4:25   ` [PATCH 20/73] ACPICA: Fix for namespace lookup problem Len Brown
2008-04-12  4:25   ` [PATCH 21/73] ACPICA: update version number to 20070919 Len Brown
2008-04-12  4:25   ` [PATCH 22/73] ACPICA: Fix for Alias operator to see target child objects Len Brown
2008-04-12  4:25   ` [PATCH 23/73] ACPICA: Fix for fault if Load() fails Len Brown
2008-04-12  4:25   ` [PATCH 24/73] ACPICA: Fix a fault when storing DdbHandle to Debug object Len Brown
2008-04-12  4:25   ` [PATCH 25/73] ACPICA: Fix for memory leak related to DdbHandle objects Len Brown
2008-04-12  4:25   ` [PATCH 26/73] ACPICA: Add a table checksum verify for Load operator Len Brown
2008-04-12  4:25   ` [PATCH 27/73] ACPICA: Add error checks to prevent faults Len Brown
2008-04-12  4:25   ` [PATCH 28/73] ACPICA: Fix for Load/LoadTable to specify load location Len Brown
2008-04-12  4:25   ` [PATCH 29/73] ACPICA: Fixed a memory leak when Device or Thermal objects referenced in packages Len Brown
2008-04-12  4:25   ` [PATCH 30/73] ACPICA: Fix for Increment/Decrement operator, incorrect type change Len Brown
2008-04-12  4:25   ` [PATCH 31/73] ACPICA: Added additional parameter validation for LoadTable Len Brown
2008-04-12  4:25   ` [PATCH 32/73] ACPICA: Update version to 20071019 Len Brown
2008-04-12  4:25   ` [PATCH 33/73] ACPICA: Cosmetic changes only, no functional changes Len Brown
2008-04-12  4:25   ` [PATCH 34/73] " Len Brown
2008-04-12  4:25   ` [PATCH 35/73] ACPICA: Cleanup of debug output Len Brown
2008-04-12  4:25   ` [PATCH 36/73] ACPICA: Fixes a problem with control method references within packages Len Brown
2008-04-12  4:25   ` [PATCH 37/73] ACPICA: Fixed a problem with FromBCD and ToBCD with some compilers Len Brown
2008-04-12  4:25   ` [PATCH 38/73] ACPICA: Fixed a problem with Index references passed as method arguments Len Brown
2008-04-12  4:25   ` [PATCH 39/73] ACPICA: Fixed a problem with CopyObject used in conjunction with the Index operator Len Brown
2008-04-12  4:25   ` [PATCH 40/73] ACPICA: Update version to 20071114 Len Brown
2008-04-12  4:25   ` [PATCH 41/73] ACPICA: Fixed a problem with AcpiGetDevices where the search of a branch of the device tree could be terminated prematurely Len Brown
2008-04-12  4:25   ` [PATCH 42/73] ACPICA: Fixed a problem with Index Fields where the Index register was incorrectly limited to a maximum of 32 bits Len Brown
2008-04-12  4:25   ` [PATCH 43/73] ACPICA: Implemented full support for deferred execution for the TermArg string arguments for DataTableRegion Len Brown
2008-04-12  4:25   ` [PATCH 44/73] ACPICA: Undo accidental checkin of not-fully-tested mutex changes Len Brown
2008-04-12  4:25   ` [PATCH 45/73] ACPICA: Implemented full argument resolution support for the BankValue argument to BankField Len Brown
2008-04-12  4:25   ` [PATCH 46/73] ACPICA: Fixed a couple memory leaks associated with "implicit return" objects when the AML Interpreter slack mode is enabled Len Brown
2008-04-22 18:24     ` Len Brown
2008-04-12  4:25   ` [PATCH 47/73] ACPICA: Update version to 20071219 Len Brown
2008-04-12  4:25   ` [PATCH 48/73] ACPICA: Fix for SizeOf when used with Buffers and Packages Len Brown
2008-04-12  4:25   ` [PATCH 49/73] ACPICA: Methods now implicitly return 0 in slack mode Len Brown
2008-04-12  4:25   ` [PATCH 50/73] ACPICA: Fix for Load operator Len Brown
2008-04-12  4:25   ` [PATCH 51/73] ACPICA: Fix for LoadTable operator, input strings Len Brown
2008-04-12  4:25   ` [PATCH 52/73] ACPICA: Include file support for new ACPI tables Len Brown
2008-04-12  4:25   ` [PATCH 53/73] ACPICA: Bulletproof disassembler for bad " Len Brown
2008-04-12  4:25   ` [PATCH 54/73] ACPICA: Fixes for Unload and DDBHandles Len Brown
2008-04-12  4:25   ` [PATCH 55/73] ACPICA: Update version to 20080123 Len Brown
2008-04-12  4:25   ` [PATCH 56/73] ACPICA: Add va_end statements as appropriate Len Brown
2008-04-12  4:25   ` [PATCH 57/73] ACPICA: Added new error messages Len Brown
2008-04-12  4:25   ` [PATCH 58/73] ACPICA: Fix for ACPI_HIDWORD macro Len Brown
2008-04-12  4:25   ` [PATCH 59/73] ACPICA: Disassembler support for new ACPI tables Len Brown
2008-04-12  4:25   ` [PATCH 60/73] ACPICA: Additional GPE/Notify handling change Len Brown
2008-04-12  4:25   ` [PATCH 61/73] ACPICA: Fix for resource descriptor optimization issues for _CRS/_SRC Len Brown
2008-04-12  4:25   ` [PATCH 62/73] ACPICA: Update behavior of CopyObject to match ACPI spec Len Brown
2008-04-12  4:25   ` [PATCH 63/73] ACPICA: Fix for possible error when packages/buffers are passed to methods externally Len Brown
2008-04-12  4:25   ` [PATCH 64/73] ACPICA: Update ACPICA version to 20080213 Len Brown
2008-04-12  4:25   ` [PATCH 65/73] ACPICA: Fix for extraneous debug message for packages Len Brown
2008-04-15  7:09     ` Len Brown
2008-04-15  8:36       ` Alexey Starikovskiy
2008-04-15 18:46         ` Moore, Robert
2008-04-15 18:56           ` Alexey Starikovskiy
2008-04-15 20:19             ` Moore, Robert
2008-04-15 20:39               ` Alexey Starikovskiy
2008-04-15 21:01                 ` Moore, Robert
2008-04-15 21:12                   ` Alexey Starikovskiy
2008-04-15 21:29                     ` Moore, Robert
2008-04-15 21:51                       ` Alexey Starikovskiy [this message]
2008-04-15 22:27                         ` Moore, Robert
2008-04-15 22:02                       ` Tomas Carnecky
2008-04-15 21:57                         ` Alexey Starikovskiy
2008-04-15 22:20                           ` Moore, Robert
2008-04-15 21:56                 ` Tomas Carnecky
2008-04-15 21:55                   ` Alexey Starikovskiy
2008-04-22 19:23         ` Len Brown
2008-04-22 22:21           ` Moore, Robert
2008-04-22 23:22             ` Len Brown
2008-04-23  1:00               ` Moore, Robert
2008-04-12  4:25   ` [PATCH 66/73] ACPICA: Fix to handle NULL package elements correctly Len Brown
2008-04-12  4:25   ` [PATCH 67/73] ACPICA: Fixes for external Reference Objects Len Brown
2008-04-22 23:15     ` Len Brown
2008-04-12  4:25   ` [PATCH 68/73] ACPICA: Updates for Debug object output Len Brown
2008-04-12  4:25   ` [PATCH 69/73] ACPICA: Fixes for size of StartDependent resource descriptor Len Brown
2008-04-12  4:25   ` [PATCH 70/73] ACPICA: Fix to disable unknown spurious GPEs Len Brown
2008-04-23  2:57     ` Len Brown
2008-04-23  5:28       ` Alexey Starikovskiy
2008-04-23 20:35         ` Moore, Robert
2008-04-25  1:40           ` Len Brown
2008-04-25  1:53             ` Zhang Rui
2008-04-25  1:57               ` Moore, Robert
2008-04-25  2:10                 ` Alexey Starikovskiy
2008-04-25  2:28                   ` Zhang Rui
2008-04-25  2:39                     ` Alexey Starikovskiy
2008-04-25  4:18                       ` Moore, Robert
2008-05-21  8:28                 ` Zhang, Rui
2008-05-21 16:56                   ` Zhang Rui
2008-05-22  1:35                     ` Zhao Yakui
2008-05-22 16:45                     ` Moore, Robert
2008-05-22 16:55                       ` Alexey Starikovskiy
2008-05-22 17:22                         ` Moore, Robert
2008-05-28 17:40                     ` Moore, Robert
2008-05-22  1:08                   ` Zhao Yakui
2008-04-12  4:25   ` [PATCH 71/73] ACPICA: Update for new Notify values Len Brown
2008-04-12  4:25   ` [PATCH 72/73] ACPICA: Update version to 20080321 Len Brown
2008-04-12  4:25   ` [PATCH 73/73] ACPICA: Fix for some local named nodes not marked temporary and to disallow duplicates Len Brown
2008-04-12  4:41 ` ACPICA branch - first try Core revision 20080321 Len Brown
2008-04-12 20:46   ` Alexey Starikovskiy
2008-04-15  7:51     ` Len Brown
2008-04-29  9:04 ` ACPICA branch (0 Objects with 0 Devices 0 Methods 0 Regions) Len Brown
2008-04-29 16:09   ` Moore, Robert
2008-04-30 11:03     ` Lin Ming
2008-05-06  6:20     ` Lin Ming
2008-05-06 17:07       ` Moore, Robert
2008-05-13  5:45       ` Lin Ming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4805235E.6090708@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=aystarik@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.