Re: patch base-files /etc/profile

[Junqian Gordon Xu <xjqian@gmail.com>]

On 04/17/2008 06:05 PM, Khem Raj wrote:
> Hi 
> 
> I was seeing that on Angstrom.2008 I was not getting TSLIB_TSDEVICE
> environment variable set though it should be as it was
> invoking /etc/profile.d/tslib.sh in /etc/profile. However the 'ls'
> command in there was not really working well.
> 
> This patch fixes the problem. Now I see TALIB_TSDEVICE variable set
> everytime.
> 
> OK for .dev ?
> 
> Thanks
> 
> -Khem
> ============================================================
> --- packages/base-files/base-files/profile
> c1afd65b969f708eab144ec909358f3c8f22a411
> +++ packages/base-files/base-files/profile
> e24b90b96edb24d3af735f32c72528e6a01d617d
> @@ -20,8 +20,10 @@ if [ -d /etc/profile.d ]; then
>  fi
>  
>  if [ -d /etc/profile.d ]; then
> -  for i in `ls /etc/profile.d/`; do
> -    . /etc/profile.d/$i
> +  for i in /etc/profile.d/*.sh; do
> +    if [ -r $i ]; then
> +      . $i
> +    fi
>    done
>    unset i
>  fi

looks good to me, but why not keep the absolute path:

. /etc/profile.d/$i

Regards
Gordon