All of lore.kernel.org
 help / color / mirror / Atom feed
* patch base-files /etc/profile
@ 2008-04-17 23:05 Khem Raj
  2008-04-17 23:55 ` Thomas Kunze
  2008-04-18  3:49 ` Junqian Gordon Xu
  0 siblings, 2 replies; 4+ messages in thread
From: Khem Raj @ 2008-04-17 23:05 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi 

I was seeing that on Angstrom.2008 I was not getting TSLIB_TSDEVICE
environment variable set though it should be as it was
invoking /etc/profile.d/tslib.sh in /etc/profile. However the 'ls'
command in there was not really working well.

This patch fixes the problem. Now I see TALIB_TSDEVICE variable set
everytime.

OK for .dev ?

Thanks

-Khem

#
# old_revision [cc8daafda388ec1e484dc2e68e1599944893bc76]
#
# patch "packages/base-files/base-files/profile"
#  from [c1afd65b969f708eab144ec909358f3c8f22a411]
#    to [e24b90b96edb24d3af735f32c72528e6a01d617d]
# 
# patch "packages/base-files/base-files_3.0.14.bb"
#  from [a35cae8a2aa502d9f36ce35fcd2dddd9a86ce2c4]
#    to [3b4da947c2b76133142ee113622e6986e653f14a]
#
============================================================
--- packages/base-files/base-files/profile
c1afd65b969f708eab144ec909358f3c8f22a411
+++ packages/base-files/base-files/profile
e24b90b96edb24d3af735f32c72528e6a01d617d
@@ -20,8 +20,10 @@ if [ -d /etc/profile.d ]; then
 fi
 
 if [ -d /etc/profile.d ]; then
-  for i in `ls /etc/profile.d/`; do
-    . /etc/profile.d/$i
+  for i in /etc/profile.d/*.sh; do
+    if [ -r $i ]; then
+      . $i
+    fi
   done
   unset i
 fi
============================================================
--- packages/base-files/base-files_3.0.14.bb
a35cae8a2aa502d9f36ce35fcd2dddd9a86ce2c4
+++ packages/base-files/base-files_3.0.14.bb
3b4da947c2b76133142ee113622e6986e653f14a
@@ -1,7 +1,7 @@ PRIORITY = "required"
 DESCRIPTION = "Miscellaneous files for the base system."
 SECTION = "base"
 PRIORITY = "required"
-PR = "r77"
+PR = "r78"
 LICENSE = "GPL"
 
 SRC_URI = " \


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 196 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch base-files /etc/profile
  2008-04-17 23:05 patch base-files /etc/profile Khem Raj
@ 2008-04-17 23:55 ` Thomas Kunze
  2008-04-18  3:49 ` Junqian Gordon Xu
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Kunze @ 2008-04-17 23:55 UTC (permalink / raw)
  To: openembedded-devel

Khem Raj wrote:
> Hi 
>
> I was seeing that on Angstrom.2008 I was not getting TSLIB_TSDEVICE
> environment variable set though it should be as it was
> invoking /etc/profile.d/tslib.sh in /etc/profile. However the 'ls'
> command in there was not really working well.
>
> This patch fixes the problem. Now I see TALIB_TSDEVICE variable set
> everytime.
>
> OK for .dev ?
>
> Thanks
>
> -Khem
>   
+1 from me.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch base-files /etc/profile
  2008-04-17 23:05 patch base-files /etc/profile Khem Raj
  2008-04-17 23:55 ` Thomas Kunze
@ 2008-04-18  3:49 ` Junqian Gordon Xu
  2008-04-18  6:57   ` Khem Raj
  1 sibling, 1 reply; 4+ messages in thread
From: Junqian Gordon Xu @ 2008-04-18  3:49 UTC (permalink / raw)
  To: openembedded-devel

On 04/17/2008 06:05 PM, Khem Raj wrote:
> Hi 
> 
> I was seeing that on Angstrom.2008 I was not getting TSLIB_TSDEVICE
> environment variable set though it should be as it was
> invoking /etc/profile.d/tslib.sh in /etc/profile. However the 'ls'
> command in there was not really working well.
> 
> This patch fixes the problem. Now I see TALIB_TSDEVICE variable set
> everytime.
> 
> OK for .dev ?
> 
> Thanks
> 
> -Khem
> ============================================================
> --- packages/base-files/base-files/profile
> c1afd65b969f708eab144ec909358f3c8f22a411
> +++ packages/base-files/base-files/profile
> e24b90b96edb24d3af735f32c72528e6a01d617d
> @@ -20,8 +20,10 @@ if [ -d /etc/profile.d ]; then
>  fi
>  
>  if [ -d /etc/profile.d ]; then
> -  for i in `ls /etc/profile.d/`; do
> -    . /etc/profile.d/$i
> +  for i in /etc/profile.d/*.sh; do
> +    if [ -r $i ]; then
> +      . $i
> +    fi
>    done
>    unset i
>  fi

looks good to me, but why not keep the absolute path:

. /etc/profile.d/$i

Regards
Gordon



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: patch base-files /etc/profile
  2008-04-18  3:49 ` Junqian Gordon Xu
@ 2008-04-18  6:57   ` Khem Raj
  0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2008-04-18  6:57 UTC (permalink / raw)
  To: openembedded-devel

On Thu, Apr 17, 2008 at 8:49 PM, Junqian Gordon Xu <xjqian@gmail.com> wrote:
> On 04/17/2008 06:05 PM, Khem Raj wrote:
>  > Hi
>  >
>  > I was seeing that on Angstrom.2008 I was not getting TSLIB_TSDEVICE
>  > environment variable set though it should be as it was
>  > invoking /etc/profile.d/tslib.sh in /etc/profile. However the 'ls'
>  > command in there was not really working well.
>  >
>  > This patch fixes the problem. Now I see TALIB_TSDEVICE variable set
>  > everytime.
>  >
>  > OK for .dev ?
>  >
>  > Thanks
>  >
>  > -Khem
>
> > ============================================================
>  > --- packages/base-files/base-files/profile
>  > c1afd65b969f708eab144ec909358f3c8f22a411
>  > +++ packages/base-files/base-files/profile
>  > e24b90b96edb24d3af735f32c72528e6a01d617d
>  > @@ -20,8 +20,10 @@ if [ -d /etc/profile.d ]; then
>  >  fi
>  >
>  >  if [ -d /etc/profile.d ]; then
>  > -  for i in `ls /etc/profile.d/`; do
>  > -    . /etc/profile.d/$i
>  > +  for i in /etc/profile.d/*.sh; do
>  > +    if [ -r $i ]; then
>  > +      . $i
>  > +    fi
>  >    done
>  >    unset i
>  >  fi
>
>  looks good to me, but why not keep the absolute path:
>
>  . /etc/profile.d/$i

Its already in $i

>
>  Regards
>  Gordon
>
>
>
>  _______________________________________________
>  Openembedded-devel mailing list
>  Openembedded-devel@lists.openembedded.org
>  http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-04-18  6:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-17 23:05 patch base-files /etc/profile Khem Raj
2008-04-17 23:55 ` Thomas Kunze
2008-04-18  3:49 ` Junqian Gordon Xu
2008-04-18  6:57   ` Khem Raj

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.