All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xenomai-core] Bug in ipipe patch?
@ 2008-04-18 17:03 Steven A. Falco
  2008-04-21 13:36 ` Philippe Gerum
  0 siblings, 1 reply; 2+ messages in thread
From: Steven A. Falco @ 2008-04-18 17:03 UTC (permalink / raw)
  To: xenomai

I don't know if this has already been reported, but I think there is a
bug in file:

    adeos-ipipe-2.6.24-powerpc-DENX-2.1-01.patch

specifically for the file ipipe.c.

The macro "EXPORT_SYMBOL_GPL(tasklist_lock)" appears in two places; once
outside of any ifdef, and once inside the "#else  /* !CONFIG_PPC64 */"
ifdef.

Consequently, when building for a 32-bit processor, I get a "redefined"
error:

/home/sfalco/linux/embedded/ppc3/linux/linux-2.6-denx/arch/powerpc/kernel/ipipe.c:747:
error: redefinition of '__kstrtab_tasklist_lock'
/home/sfalco/linux/embedded/ppc3/linux/linux-2.6-denx/arch/powerpc/kernel/ipipe.c:724:
error: previous definition of '__kstrtab_tasklist_lock' was here

    Steve



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Xenomai-core] Bug in ipipe patch?
  2008-04-18 17:03 [Xenomai-core] Bug in ipipe patch? Steven A. Falco
@ 2008-04-21 13:36 ` Philippe Gerum
  0 siblings, 0 replies; 2+ messages in thread
From: Philippe Gerum @ 2008-04-21 13:36 UTC (permalink / raw)
  To: Steven A. Falco; +Cc: xenomai

Steven A. Falco wrote:
> I don't know if this has already been reported, but I think there is a
> bug in file:
> 
>     adeos-ipipe-2.6.24-powerpc-DENX-2.1-01.patch
> 
> specifically for the file ipipe.c.
> 
> The macro "EXPORT_SYMBOL_GPL(tasklist_lock)" appears in two places; once
> outside of any ifdef, and once inside the "#else  /* !CONFIG_PPC64 */"
> ifdef.
> 
> Consequently, when building for a 32-bit processor, I get a "redefined"
> error:
> 
> /home/sfalco/linux/embedded/ppc3/linux/linux-2.6-denx/arch/powerpc/kernel/ipipe.c:747:
> error: redefinition of '__kstrtab_tasklist_lock'
> /home/sfalco/linux/embedded/ppc3/linux/linux-2.6-denx/arch/powerpc/kernel/ipipe.c:724:
> error: previous definition of '__kstrtab_tasklist_lock' was here
>

Fixed in my tree, thanks.

>     Steve
> 
> 
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
> 


-- 
Philippe.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-21 13:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 17:03 [Xenomai-core] Bug in ipipe patch? Steven A. Falco
2008-04-21 13:36 ` Philippe Gerum

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.