All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] w6692: replace deprecated pci_find_device
  2008-04-20 10:04 [PATCH] w6692: replace deprecated pci_find_device Udo van den Heuvel
@ 2008-04-20  9:41 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2008-04-20  9:41 UTC (permalink / raw)
  To: Udo van den Heuvel; +Cc: LKML

On Sun, 20 Apr 2008 12:04:10 +0200
Udo van den Heuvel <udovdh@xs4all.nl> wrote:

> Hello,
> 
> Found this is still necessary for 2.6.25 for the w6692 hisax isdn cards.
> Maybe someone has already prepared a patch?
> If not you could use this one.
> 
> 
> 1. replace deprecated pci_find_device
> 
> Signed-off-by: Udo van den Heuvel <udovdh@xs4all.nl>

NAK. You can't simply replace it - you need to make correct use of
pci_dev_put as well.

Alan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] w6692: replace deprecated pci_find_device
@ 2008-04-20 10:04 Udo van den Heuvel
  2008-04-20  9:41 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Udo van den Heuvel @ 2008-04-20 10:04 UTC (permalink / raw)
  To: LKML

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

Hello,

Found this is still necessary for 2.6.25 for the w6692 hisax isdn cards.
Maybe someone has already prepared a patch?
If not you could use this one.


1. replace deprecated pci_find_device

Signed-off-by: Udo van den Heuvel <udovdh@xs4all.nl>

Kind regards,
Udo

[-- Attachment #2: w6692.patch --]
[-- Type: text/x-patch, Size: 409 bytes --]

--- a/drivers/isdn/hisax/w6692.c	2008-04-20 11:57:26.000000000 +0200
+++ b/drivers/isdn/hisax/w6692.c	2008-04-20 11:57:48.000000000 +0200
@@ -1011,7 +1011,7 @@
 		return (0);
 
 	while (id_list[id_idx].vendor_id) {
-		dev_w6692 = pci_find_device(id_list[id_idx].vendor_id,
+		dev_w6692 = pci_get_device(id_list[id_idx].vendor_id,
 					    id_list[id_idx].device_id,
 					    dev_w6692);
 		if (dev_w6692) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-20 10:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-20 10:04 [PATCH] w6692: replace deprecated pci_find_device Udo van den Heuvel
2008-04-20  9:41 ` Alan Cox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.