From: Paulius Zaleckas <paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] updated Patch to option HSO driver to the kernel
Date: Tue, 22 Apr 2008 11:33:14 +0300 [thread overview]
Message-ID: <480DA2CA.8090705@teltonika.lt> (raw)
In-Reply-To: <480CB8C2.9090902-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 58 bytes --]
Incremental patch.
- use net_device_stats from dev->stats
[-- Attachment #2: hso_net_stats.patch --]
[-- Type: text/x-patch, Size: 2078 bytes --]
--- linux-2.6-hso-my/drivers/net/usb/hso.c.orig 2008-04-21 18:45:43.000000000 +0300
+++ linux-2.6-hso-my/drivers/net/usb/hso.c 2008-04-22 11:16:01.000000000 +0300
@@ -152,7 +152,6 @@ struct hso_shared_int {
struct hso_net {
struct hso_device *parent;
- struct net_device_stats stats;
struct net_device *net;
struct usb_endpoint_descriptor *in_endp;
@@ -712,7 +711,7 @@ static int hso_net_open(struct net_devic
return -ENODEV;
}
/* reset read counter. */
- odev->stats.rx_packets = 0;
+ odev->net->stats.rx_packets = 0;
odev->skb_tx_buf = NULL;
/* setup environment */
@@ -817,11 +816,11 @@ static int hso_net_start_xmit(struct sk_
if (result) {
dev_warn(&odev->parent->interface->dev,
"failed mux_bulk_tx_urb %d", result);
- odev->stats.tx_errors++;
+ odev->net->stats.tx_errors++;
netif_start_queue(net);
} else {
- odev->stats.tx_packets++;
- odev->stats.tx_bytes += skb->len;
+ odev->net->stats.tx_packets++;
+ odev->net->stats.tx_bytes += skb->len;
/* And tell the kernel when the last transmit started. */
net->trans_start = jiffies;
}
@@ -846,7 +845,7 @@ static struct ethtool_ops ops = {
static struct net_device_stats *hso_net_get_stats(struct net_device *net)
{
- return &((struct hso_net *)netdev_priv(net))->stats;
+ return &net->stats;
}
/* called when a packet did not ack after watchdogtimeout */
@@ -866,7 +865,7 @@ static void hso_net_tx_timeout(struct ne
usb_unlink_urb(odev->mux_bulk_tx_urb);
/* Update statistics */
- odev->stats.tx_errors++;
+ odev->net->stats.tx_errors++;
}
/* make a real packet from the received USB buffer */
@@ -991,11 +990,11 @@ static void packetizeRx(struct hso_net *
odev->skb_rx_buf = NULL;
/* update out statistics */
- odev->stats.rx_packets++;
+ odev->net->stats.rx_packets++;
/* Hmmm, wonder if we have received the IP len
* or the ETH len. */
- odev->stats.rx_bytes += odev->rx_buf_size;
+ odev->net->stats.rx_bytes += odev->rx_buf_size;
odev->rx_buf_size = 0;
odev->rx_buf_missing = sizeof(struct iphdr);
next prev parent reply other threads:[~2008-04-22 8:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 21:47 [RFC] updated Patch to option HSO driver to the kernel Greg KH
[not found] ` <20080417214719.GF17664-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-21 1:04 ` Paulius Zaleckas
2008-04-21 8:16 ` Oliver Neukum
2008-04-21 9:34 ` Paulius Zaleckas
[not found] ` <480C5FAF.1050408-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 18:41 ` David Brownell
[not found] ` <20080421184157.106603602C8-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-04-21 22:04 ` Paulius Zaleckas
2008-04-21 22:58 ` David Brownell
[not found] ` <480D0F5B.9010808-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-22 6:29 ` Filip Aben
2008-04-22 8:52 ` Oliver Neukum
[not found] ` <480BE815.2000409-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 15:54 ` Paulius Zaleckas
[not found] ` <480CB8C2.9090902-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 20:17 ` David Brownell
[not found] ` <200804211317.23971.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-04-21 22:12 ` Paulius Zaleckas
2008-04-22 8:33 ` Paulius Zaleckas [this message]
[not found] ` <480DA2CA.8090705-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-22 13:50 ` Paulius Zaleckas
[not found] ` <480DED38.3080900-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-23 13:40 ` Paulius Zaleckas
[not found] ` <480F3C41.10908-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-25 12:31 ` Paulius Zaleckas
2008-04-25 13:03 ` Oliver Neukum
[not found] ` <200804251503.31240.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-25 16:09 ` Christoph Hellwig
[not found] ` <4811CF33.8040007-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-25 13:19 ` Paulius Zaleckas
[not found] ` <4811DA4F.30209-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-28 10:53 ` Paulius Zaleckas
[not found] ` <4815AC9D.7080009-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-28 15:37 ` Paulius Zaleckas
2008-04-21 12:43 ` Paulius Zaleckas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480DA2CA.8090705@teltonika.lt \
--to=paulius.zaleckas-ft0m5q12rq9xbeleqiml3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.