All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
To: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [RFC] updated Patch to option HSO driver to the kernel
Date: Fri, 25 Apr 2008 15:31:47 +0300	[thread overview]
Message-ID: <4811CF33.8040007@teltonika.lt> (raw)
In-Reply-To: <480F3C41.10908-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Incremental patch.
- don't reset rx_packets stats when telling device "up".

TODO:
- figure out what should be MTU value. Currently it is set
   to 1500-14. I guess that 14 here means eth header size, but
   this has no logical explanation...
- do we really need ethtool support? It always reports that
   link is up... The only useful information is driver name,
   version and USB path... Is it worth it?

[-- Attachment #2: hso_reset_rx.patch --]
[-- Type: text/x-patch, Size: 411 bytes --]

--- linux-2.6-hso-my/drivers/net/usb/hso.c.orig	2008-04-23 16:24:30.000000000 +0300
+++ linux-2.6-hso-my/drivers/net/usb/hso.c	2008-04-25 15:12:48.000000000 +0300
@@ -693,8 +693,7 @@ static int hso_net_open(struct net_devic
 		dev_err(&net->dev, "No net device !\n");
 		return -ENODEV;
 	}
-	/* reset read counter. */
-	odev->net->stats.rx_packets = 0;
+
 	odev->skb_tx_buf = NULL;
 
 	/* setup environment */

  parent reply	other threads:[~2008-04-25 12:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 21:47 [RFC] updated Patch to option HSO driver to the kernel Greg KH
     [not found] ` <20080417214719.GF17664-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2008-04-21  1:04   ` Paulius Zaleckas
2008-04-21  8:16     ` Oliver Neukum
2008-04-21  9:34       ` Paulius Zaleckas
     [not found]         ` <480C5FAF.1050408-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 18:41           ` David Brownell
     [not found]             ` <20080421184157.106603602C8-ZcXrCSuhvln6VZ3dlLfH/g4gEjPzgfUyLrfjE7I9kuVHxeISYlDBzl6hYfS7NtTn@public.gmane.org>
2008-04-21 22:04               ` Paulius Zaleckas
2008-04-21 22:58                 ` David Brownell
     [not found]                 ` <480D0F5B.9010808-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-22  6:29                   ` Filip Aben
2008-04-22  8:52                   ` Oliver Neukum
     [not found]     ` <480BE815.2000409-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 15:54       ` Paulius Zaleckas
     [not found]         ` <480CB8C2.9090902-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-21 20:17           ` David Brownell
     [not found]             ` <200804211317.23971.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-04-21 22:12               ` Paulius Zaleckas
2008-04-22  8:33           ` Paulius Zaleckas
     [not found]             ` <480DA2CA.8090705-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-22 13:50               ` Paulius Zaleckas
     [not found]                 ` <480DED38.3080900-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-23 13:40                   ` Paulius Zaleckas
     [not found]                     ` <480F3C41.10908-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-25 12:31                       ` Paulius Zaleckas [this message]
2008-04-25 13:03                         ` Oliver Neukum
     [not found]                           ` <200804251503.31240.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2008-04-25 16:09                             ` Christoph Hellwig
     [not found]                         ` <4811CF33.8040007-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-25 13:19                           ` Paulius Zaleckas
     [not found]                             ` <4811DA4F.30209-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-28 10:53                               ` Paulius Zaleckas
     [not found]                                 ` <4815AC9D.7080009-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2008-04-28 15:37                                   ` Paulius Zaleckas
2008-04-21 12:43   ` Paulius Zaleckas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4811CF33.8040007@teltonika.lt \
    --to=paulius.zaleckas-ft0m5q12rq9xbeleqiml3w@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.