* [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
@ 2008-04-23 2:26 ` Li Zefan
0 siblings, 0 replies; 6+ messages in thread
From: Li Zefan @ 2008-04-23 2:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: Balbir Singh, KAMEZAWA Hiroyuki, LKML, linux-mm@kvack.org
*mem has been zeroed, that means mem->info has already
been filled with 0.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
mm/memcontrol.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index eefa750..020e8f5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1014,8 +1014,6 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
res_counter_init(&mem->res);
- memset(&mem->info, 0, sizeof(mem->info));
-
for_each_node_state(node, N_POSSIBLE)
if (alloc_mem_cgroup_per_zone_info(mem, node))
goto free_out;
-- 1.5.4.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
@ 2008-04-23 2:26 ` Li Zefan
0 siblings, 0 replies; 6+ messages in thread
From: Li Zefan @ 2008-04-23 2:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: Balbir Singh, KAMEZAWA Hiroyuki, LKML, linux-mm@kvack.org
*mem has been zeroed, that means mem->info has already
been filled with 0.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
mm/memcontrol.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index eefa750..020e8f5 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1014,8 +1014,6 @@ mem_cgroup_create(struct cgroup_subsys *ss, struct cgroup *cont)
res_counter_init(&mem->res);
- memset(&mem->info, 0, sizeof(mem->info));
-
for_each_node_state(node, N_POSSIBLE)
if (alloc_mem_cgroup_per_zone_info(mem, node))
goto free_out;
-- 1.5.4.rc3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
2008-04-23 2:26 ` Li Zefan
@ 2008-04-23 2:50 ` KAMEZAWA Hiroyuki
-1 siblings, 0 replies; 6+ messages in thread
From: KAMEZAWA Hiroyuki @ 2008-04-23 2:50 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, Balbir Singh, LKML, linux-mm@kvack.org
On Wed, 23 Apr 2008 10:26:26 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> *mem has been zeroed, that means mem->info has already
> been filled with 0.
>
maybe my mistake :(
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
@ 2008-04-23 2:50 ` KAMEZAWA Hiroyuki
0 siblings, 0 replies; 6+ messages in thread
From: KAMEZAWA Hiroyuki @ 2008-04-23 2:50 UTC (permalink / raw)
To: Li Zefan; +Cc: Andrew Morton, Balbir Singh, LKML, linux-mm@kvack.org
On Wed, 23 Apr 2008 10:26:26 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> *mem has been zeroed, that means mem->info has already
> been filled with 0.
>
maybe my mistake :(
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
2008-04-23 2:50 ` KAMEZAWA Hiroyuki
@ 2008-04-23 3:02 ` Balbir Singh
-1 siblings, 0 replies; 6+ messages in thread
From: Balbir Singh @ 2008-04-23 3:02 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: Li Zefan, Andrew Morton, LKML, linux-mm@kvack.org
KAMEZAWA Hiroyuki wrote:
> On Wed, 23 Apr 2008 10:26:26 +0800
> Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> *mem has been zeroed, that means mem->info has already
>> been filled with 0.
>>
> maybe my mistake :(
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] memcg: remove redundant initialization in mem_cgroup_create()
@ 2008-04-23 3:02 ` Balbir Singh
0 siblings, 0 replies; 6+ messages in thread
From: Balbir Singh @ 2008-04-23 3:02 UTC (permalink / raw)
To: KAMEZAWA Hiroyuki; +Cc: Li Zefan, Andrew Morton, LKML, linux-mm@kvack.org
KAMEZAWA Hiroyuki wrote:
> On Wed, 23 Apr 2008 10:26:26 +0800
> Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> *mem has been zeroed, that means mem->info has already
>> been filled with 0.
>>
> maybe my mistake :(
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com>
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-04-23 3:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 2:26 [PATCH] memcg: remove redundant initialization in mem_cgroup_create() Li Zefan
2008-04-23 2:26 ` Li Zefan
2008-04-23 2:50 ` KAMEZAWA Hiroyuki
2008-04-23 2:50 ` KAMEZAWA Hiroyuki
2008-04-23 3:02 ` Balbir Singh
2008-04-23 3:02 ` Balbir Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.