Re: [PATCH] Fix VIDIOCGAP corruption in ivtv

[mkrufky@linuxtv.org]

Mauro Carvalho Chehab wrote:
> On Sun, 20 Apr 2008 12:10:00 -0400
> Michael Krufky <mkrufky@linuxtv.org> wrote:
>
>   
>> Hans Verkuil wrote:
>>     
>>> On Sunday 20 April 2008 13:27:36 Alan Cox wrote:
>>>   
>>>       
>>>> Frank Bennett reported that ivtv was causing skype to crash. With
>>>> help from one of their developers he showed it was a kernel problem.
>>>> VIDIOCGCAP copies a name into a fixed length buffer - ivtv uses names
>>>> that are too long and does not truncate them so corrupts a few bytes
>>>> of the app data area.
>>>>
>>>> Possibly the names also want trimming but for now this should fix the
>>>> corruption case.
>>>>     
>>>>         
>>> Ouch, nasty one.
>>>
>>> Mauro, can you apply this patch to the v4l-dvb master?
>>>
>>> Mike, this one should obviously go into a 2.6.25 dot-release, and I 
>>> think also to a 2.6.24 dot-release.
>>>
>>> Frank, thank you for reporting this!
>>>
>>> 	Hans
>>>
>>> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>>>   
>>>       
>> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
>>     
>
> In this case, it should be reviewed-by.
>
> I should be sending this soon to Linus.


Mauro,

I think it's wrong that you alter signatures.  You did this:

Reviewed-by: <mkrufky@linuxtv.org <mailto:mkrufky@linuxtv.org>>

But I provided this:

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>

I sign the patch, because I have handled it in my -stable queue.


You put my email address without my name!

A signature is sacred and nobody should fudge it.

Please fix it before you send to -git.

-Mike