From: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: yoichi_yuasa@tripeaks.co.jp, ralf@linux-mips.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] [MIPS] add DECstation DS1287 clockevent
Date: Wed, 23 Apr 2008 22:44:54 +0400 [thread overview]
Message-ID: <480F83A6.50308@gmail.com> (raw)
In-Reply-To: <20080423.115528.59033169.nemoto@toshiba-tops.co.jp>
Atsushi Nemoto пишет:
> On Wed, 23 Apr 2008 08:52:45 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
>> add DECstation DS1287 clockevent
>>
>> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> ...
>> --- linux-orig/arch/mips/kernel/Makefile 2008-04-22 19:01:43.957134178 +0900
>> +++ linux/arch/mips/kernel/Makefile 2008-04-22 18:03:05.427649422 +0900
>> @@ -9,8 +9,9 @@ obj-y += cpu-probe.o branch.o entry.o g
>> time.o topology.o traps.o unaligned.o
>>
>> obj-$(CONFIG_CEVT_BCM1480) += cevt-bcm1480.o
>> -obj-$(CONFIG_CEVT_R4K) += cevt-r4k.o
>> +obj-$(CONFIG_CEVT_DS1287) += cevt-ds1287.o
>> obj-$(CONFIG_CEVT_GT641XX) += cevt-gt641xx.o
>> +obj-$(CONFIG_CEVT_R4K) += cevt-r4k.o
>> obj-$(CONFIG_CEVT_SB1250) += cevt-sb1250.o
>> obj-$(CONFIG_CEVT_TXX9) += cevt-txx9.o
>> obj-$(CONFIG_CSRC_BCM1480) += csrc-bcm1480.o
>
> Why CONFIG_CEVT_R4K line was moved? The order is important?
>
>> --- linux-orig/arch/mips/kernel/cevt-ds1287.c 1970-01-01 09:00:00.000000000 +0900
>> +++ linux/arch/mips/kernel/cevt-ds1287.c 2008-04-22 18:03:05.455637018 +0900
> ...
>> +static void ds1287_set_mode(enum clock_event_mode mode,
>> + struct clock_event_device *evt)
>> +{
>> + unsigned long flags;
>> + u8 val;
>> +
>> + spin_lock_irqsave(&rtc_lock, flags);
>
> You do not have to use irqsave here, while set_mode is always called
> with interrupts disabled. And for rtc_lock ... I don't know if this
> code could be used on SMP :-)
>
After I had saved a DECstation 5000/200 from a junkyard a few years
ago (very neat hardware, actually), I did some research on this brand.
AFAICT, all MIPS-based DECstation models were UP.
Dmitri
next prev parent reply other threads:[~2008-04-23 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 23:51 [PATCH 1/2] [MIPS] add DECstation I/O ASIC clocksource Yoichi Yuasa
2008-04-22 23:52 ` [PATCH 2/2] [MIPS] add DECstation DS1287 clockevent Yoichi Yuasa
2008-04-23 2:55 ` Atsushi Nemoto
2008-04-23 4:07 ` Yoichi Yuasa
2008-04-23 18:44 ` Dmitri Vorobiev [this message]
2008-04-23 22:31 ` Maciej W. Rozycki
2008-04-23 0:46 ` [PATCH 1/2] [MIPS] add DECstation I/O ASIC clocksource Maciej W. Rozycki
2008-04-23 1:46 ` Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480F83A6.50308@gmail.com \
--to=dmitri.vorobiev@gmail.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.