[PATCH] sparc: fix drivers/video/tcx.c warning

[PATCH] sparc: fix drivers/video/tcx.c warning

[Robert Reif]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Fix compile warning:

CC drivers/video/tcx.o
drivers/video/tcx.c: In function ‘tcx_init_one’:
drivers/video/tcx.c:477: warning: format ‘%lx’ expects type ‘long 
unsigned int’, but argument 4 has type ‘resource_size_t’

This was the only sparc driver to use the resource directly in the
printk so I changed it to physbase like the other drivers.
Boot tested on SS4.

Signed-off-by: Robert Reif <reif@earthlink.net>


[-- Attachment #2: tcx.diff.txt --]
[-- Type: text/plain, Size: 717 bytes --]

diff --git a/drivers/video/tcx.c b/drivers/video/tcx.c
index e5a9ddb..fd94dfb 100644
--- a/drivers/video/tcx.c
+++ b/drivers/video/tcx.c
@@ -419,7 +419,7 @@ static int __devinit tcx_init_one(struct of_device *op)
 		par->mmap_map[6].size = SBUS_MMAP_EMPTY;
 	}
 
-	par->physbase = 0;
+	par->physbase = op->resource[0].start;
 	par->which_io = op->resource[0].flags & IORESOURCE_BITS;
 
 	for (i = 0; i < TCX_MMAP_ENTRIES; i++) {
@@ -473,7 +473,7 @@ static int __devinit tcx_init_one(struct of_device *op)
 	printk("%s: TCX at %lx:%lx, %s\n",
 	       dp->full_name,
 	       par->which_io,
-	       op->resource[0].start,
+	       par->physbase,
 	       par->lowdepth ? "8-bit only" : "24-bit depth");
 
 	return 0;

Re: [PATCH] sparc: fix drivers/video/tcx.c warning

[David Miller]

From: Robert Reif <reif@earthlink.net>
Date: Fri, 25 Apr 2008 23:22:28 -0400

> Fix compile warning:
> 
> CC drivers/video/tcx.o
> drivers/video/tcx.c: In function ‘tcx_init_one’:
> drivers/video/tcx.c:477: warning: format ‘%lx’ expects type ‘long 
> unsigned int’, but argument 4 has type ‘resource_size_t’
> 
> This was the only sparc driver to use the resource directly in the
> printk so I changed it to physbase like the other drivers.
> Boot tested on SS4.
> 
> Signed-off-by: Robert Reif <reif@earthlink.net>

Thanks a lot for this bug fix, patch applied!
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¬¥ªÜ–)îÇø§¶\x17›¡Ü¨}©ž²Æ zÚ&j:+v‰¨þø\x1e¯ù\x1e®w¥þŠà2ŠÞ™¨è­Ú&¢)ß¡«a¶Úÿÿûàz¿äz¹Þ—ú+ƒùšŽŠÝ¢jÿŠwèþ^[f