From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [PATCH -rt 1/4] x86_64: send NMI after nmi_show_regs on
Date: Mon, 28 Apr 2008 11:14:39 -0700 [thread overview]
Message-ID: <4816140F.50005@ct.jp.nec.com> (raw)
In-Reply-To: <48161325.1080508@ct.jp.nec.com>
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
The flags nmi_show_regs should be set before send NMI.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
arch/x86/kernel/nmi_64.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/nmi_64.c b/arch/x86/kernel/nmi_64.c
index d187ab9..69cc737 100644
--- a/arch/x86/kernel/nmi_64.c
+++ b/arch/x86/kernel/nmi_64.c
@@ -327,11 +327,11 @@ void nmi_show_all_regs(void)
if (system_state == SYSTEM_BOOTING)
return;
- smp_send_nmi_allbutself();
WARNING: multiple messages have this Message-ID (diff)
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: [PATCH -rt 1/4] x86_64: send NMI after nmi_show_regs on
Date: Mon, 28 Apr 2008 11:14:39 -0700 [thread overview]
Message-ID: <4816140F.50005@ct.jp.nec.com> (raw)
In-Reply-To: <48161325.1080508@ct.jp.nec.com>
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
The flags nmi_show_regs should be set before send NMI.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
---
arch/x86/kernel/nmi_64.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/nmi_64.c b/arch/x86/kernel/nmi_64.c
index d187ab9..69cc737 100644
--- a/arch/x86/kernel/nmi_64.c
+++ b/arch/x86/kernel/nmi_64.c
@@ -327,11 +327,11 @@ void nmi_show_all_regs(void)
if (system_state == SYSTEM_BOOTING)
return;
- smp_send_nmi_allbutself();
-
for_each_online_cpu(i)
nmi_show_regs[i] = 1;
+ smp_send_nmi_allbutself();
+
for_each_online_cpu(i) {
while (nmi_show_regs[i] == 1)
barrier();
--
1.5.4.1
next prev parent reply other threads:[~2008-04-28 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 18:10 [PATCH -rt 0/4] nmi_watchdog fixes for -rt Hiroshi Shimamoto
2008-04-28 18:14 ` Hiroshi Shimamoto [this message]
2008-04-28 18:14 ` [PATCH -rt 1/4] x86_64: send NMI after nmi_show_regs on Hiroshi Shimamoto
2008-04-28 19:00 ` Steven Rostedt
2008-04-28 21:34 ` Hiroshi Shimamoto
2008-04-28 18:16 ` [PATCH -rt 2/4] x86: return true for NMI handled Hiroshi Shimamoto
2008-04-28 18:17 ` [PATCH -rt 3/4] x86: nmi_watchdog NMI needed for irq_show_regs_callback() Hiroshi Shimamoto
2008-04-28 18:17 ` Hiroshi Shimamoto
2008-04-28 18:19 ` [PATCH -rt 4/4] wait for finish show_regs() before panic Hiroshi Shimamoto
2008-04-28 19:03 ` [PATCH -rt 0/4] nmi_watchdog fixes for -rt Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4816140F.50005@ct.jp.nec.com \
--to=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.