From: E Shattow <e@freeshell.de>
To: Hung-Chun Tseng <alan.tseng.cs@gmail.com>,
Yixun Lan <dlan@kernel.org>, Huan Zhou <pericycle.cc@gmail.com>,
Eric Chung <eric.chung@riscstar.com>
Cc: Tom Rini <trini@konsulko.com>, Guodong Xu <docular.xu@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
u-boot-spacemit@groups.io, u-boot@lists.u-boot-project.org
Subject: Re: [PATCH 1/2] configs: k1: enable GigaDevice SPI NOR flash support
Date: Tue, 27 Oct 2026 10:54:16 -0700 [thread overview]
Message-ID: <4817a138-b88d-4d1d-8a93-d014139901d8@freeshell.de> (raw)
In-Reply-To: <20261027154347.1392094-2-alan.tseng.cs@gmail.com>
On 10/27/26 08:43, Hung-Chun Tseng wrote:
> The Milk-V Jupiter boots from a GigaDevice GD25Q64 SPI NOR flash, but
> spacemit_k1_defconfig only enables the Winbond ID table, so neither the
> SPL nor U-Boot proper can detect it:
>
> jedec_spi_nor flash@0: unrecognized JEDEC id bytes: c8, 40, 17
>
> Enable SPI_FLASH_GIGADEVICE. With it, "sf probe" on a Jupiter reports:
>
> SF: Detected gd25q64 with page size 256 Bytes, erase size 4 KiB, total 8 MiB
>
> Signed-off-by: Hung-Chun Tseng <alan.tseng.cs@gmail.com>
> ---
> configs/spacemit_k1_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/spacemit_k1_defconfig b/configs/spacemit_k1_defconfig
> index 8ee9baa13..b8f777e89 100644
> --- a/configs/spacemit_k1_defconfig
> +++ b/configs/spacemit_k1_defconfig
> @@ -88,6 +88,7 @@ CONFIG_MMC_HS400_ES_SUPPORT=y
> CONFIG_MMC_HS400_SUPPORT=y
> CONFIG_MMC_SDHCI=y
> CONFIG_MMC_SDHCI_SPACEMIT=y
> +CONFIG_SPI_FLASH_GIGADEVICE=y
> CONFIG_SPI_FLASH_WINBOND=y
> CONFIG_NVME_PCI=y
> CONFIG_PCIE_DW_SPACEMIT=y
LGTM
Reviewed-by: E Shattow <e@freeshell.de>
next prev parent reply other threads:[~2026-10-27 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 15:43 [PATCH 0/2] spacemit: k1: two small fixes found on a Milk-V Jupiter Hung-Chun Tseng
2026-10-27 15:43 ` [PATCH 1/2] configs: k1: enable GigaDevice SPI NOR flash support Hung-Chun Tseng
2026-10-27 17:54 ` E Shattow [this message]
2026-10-27 15:43 ` [PATCH 2/2] spacemit: k1: initialise the EEPROM index in read_ddr_info() Hung-Chun Tseng
2026-10-27 17:55 ` E Shattow
2026-10-27 21:48 ` [PATCH 0/2] spacemit: k1: two small fixes found on a Milk-V Jupiter Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4817a138-b88d-4d1d-8a93-d014139901d8@freeshell.de \
--to=e@freeshell.de \
--cc=alan.tseng.cs@gmail.com \
--cc=dlan@kernel.org \
--cc=docular.xu@gmail.com \
--cc=eric.chung@riscstar.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.