From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>, Tejun Heo <htejun@gmail.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: [PATCH 10/12] sata_mv libata: export ata_eh_analyze_ncq_error
Date: Fri, 02 May 2008 02:14:53 -0400 [thread overview]
Message-ID: <481AB15D.5020201@rtr.ca> (raw)
In-Reply-To: <481AB12A.3030102@rtr.ca>
Export ata_eh_analyze_ncq_error() for subsequent use by sata_mv,
as suggested by Tejun.
Signed-off-by: Mark Lord <mlord@pobox.com>
---
checkpatch.pl complains about the new EXPORT not following the function,
but it is done here the same as for all other libata-eh functions.
--- old/drivers/ata/libata-core.c 2008-05-01 15:37:20.000000000 -0400
+++ linux/drivers/ata/libata-core.c 2008-05-01 18:57:09.000000000 -0400
@@ -6292,6 +6292,7 @@
EXPORT_SYMBOL_GPL(ata_eh_thaw_port);
EXPORT_SYMBOL_GPL(ata_eh_qc_complete);
EXPORT_SYMBOL_GPL(ata_eh_qc_retry);
+EXPORT_SYMBOL_GPL(ata_eh_analyze_ncq_error);
EXPORT_SYMBOL_GPL(ata_do_eh);
EXPORT_SYMBOL_GPL(ata_std_error_handler);
--- old/drivers/ata/libata-eh.c 2008-04-29 11:04:16.000000000 -0400
+++ linux/drivers/ata/libata-eh.c 2008-05-01 18:56:42.000000000 -0400
@@ -1357,7 +1357,7 @@
* LOCKING:
* Kernel thread context (may sleep).
*/
-static void ata_eh_analyze_ncq_error(struct ata_link *link)
+void ata_eh_analyze_ncq_error(struct ata_link *link)
{
struct ata_port *ap = link->ap;
struct ata_eh_context *ehc = &link->eh_context;
--- old/include/linux/libata.h 2008-05-01 15:37:21.000000000 -0400
+++ linux/include/linux/libata.h 2008-05-01 18:57:36.000000000 -0400
@@ -1039,6 +1039,7 @@
extern void ata_eh_qc_complete(struct ata_queued_cmd *qc);
extern void ata_eh_qc_retry(struct ata_queued_cmd *qc);
+extern void ata_eh_analyze_ncq_error(struct ata_link *link);
extern void ata_do_eh(struct ata_port *ap, ata_prereset_fn_t prereset,
ata_reset_fn_t softreset, ata_reset_fn_t hardreset,
next prev parent reply other threads:[~2008-05-02 6:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 6:07 [PATCH 00/12] sata_mv: The last big set for 2.6.26 Mark Lord
2008-05-02 6:07 ` [PATCH 01/12] sata_mv more cosmetic changes Mark Lord
2008-05-02 6:08 ` [PATCH 02/12] sata_mv pci features Mark Lord
2008-05-02 6:09 ` [PATCH 03/12] sata_mv wait for empty+idle Mark Lord
2008-05-02 6:10 ` [PATCH 04/12] sata_mv new mv_qc_defer method Mark Lord
2008-05-02 6:10 ` [PATCH 05/12] sata_mv errata workaround for sata25 part 1 Mark Lord
2008-05-02 6:11 ` [PATCH 06/12] sata_mv rearrange mv_config_fbs Mark Lord
2008-05-02 6:12 ` [PATCH 07/12] sata_mv NCQ and SError fixes for mv_err_intr Mark Lord
2008-05-02 6:13 ` [PATCH 08/12] sata_mv fix mv_host_intr bug for hc_irq_cause Mark Lord
2008-05-02 6:14 ` [PATCH 09/12] sata_mv new mv_port_intr function Mark Lord
2008-05-02 6:14 ` Mark Lord [this message]
2008-05-02 6:15 ` [PATCH 11/12] sata_mv delayed eh handling Mark Lord
2008-05-02 6:16 ` [PATCH 12/12] sata_mv NCQ-EH for FIS-based switching Mark Lord
2008-05-02 12:44 ` Mark Lord
2008-05-02 16:52 ` Grant Grundler
2008-05-02 16:54 ` Grant Grundler
2008-05-02 17:46 ` Mark Lord
2008-05-02 17:52 ` Alan Cox
2008-05-02 17:56 ` [PATCH 13/13] sata_mv use hweight16() for bit counting Mark Lord
2008-05-02 18:02 ` Mark Lord
2008-05-02 18:02 ` [PATCH 13/13] sata_mv use hweight16() for bit counting (V2) Mark Lord
2008-05-02 18:31 ` Grant Grundler
2008-05-02 16:42 ` [PATCH 03/12] sata_mv wait for empty+idle Grant Grundler
2008-05-02 17:45 ` Mark Lord
2008-05-02 18:39 ` Grant Grundler
2008-05-02 20:09 ` Mark Lord
2008-05-02 16:06 ` [PATCH 02/12] sata_mv pci features Grant Grundler
2008-05-02 17:41 ` Mark Lord
2008-05-02 18:28 ` Grant Grundler
2008-05-06 14:10 ` [PATCH 01/12] sata_mv more cosmetic changes Jeff Garzik
2008-05-06 17:57 ` Mark Lord
2008-05-06 14:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481AB15D.5020201@rtr.ca \
--to=liml@rtr.ca \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.