From: Stas Sergeev <stsp@aknet.ru>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Linux kernel <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@suse.cz>,
Michael Opdenacker <michael-lists@free-electrons.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [patch][resend] pcspkr: fix dependancies
Date: Sun, 04 May 2008 08:22:32 +0400 [thread overview]
Message-ID: <481D3A08.2040500@aknet.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
Thomas Gleixner wrote:
> The input changes need to go via Dimitry, the x86 part can go in the
> same commit.
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
Dmitry, would you mind applying this one?
If not, then I see no way to get either
fix applied...
---
fix pcspkr dependancies: make the pcspkr platform
drivers to depend on a platform device, and
not the other way around.
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
CC: Vojtech Pavlik <vojtech@suse.cz>
CC: Michael Opdenacker <michael-lists@free-electrons.com>
CC: Takashi Iwai <tiwai@suse.de>
[-- Attachment #2: pcsp_dep2.diff --]
[-- Type: text/x-patch, Size: 1315 bytes --]
--- a/init/Kconfig 2008-04-26 13:40:20.000000000 +0400
+++ b/init/Kconfig 2008-04-26 18:20:40.000000000 +0400
@@ -624,6 +624,14 @@
help
Enable support for generating core dumps. Disabling saves about 4k.
+config PCSPKR_PLATFORM
+ bool "Enable PC-Speaker support" if EMBEDDED
+ depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ default y
+ help
+ This option allows to disable the internal PC-Speaker
+ support, saving some memory.
+
config COMPAT_BRK
bool "Disable heap randomization"
default y
--- a/arch/x86/kernel/Makefile 2008-04-26 13:40:06.000000000 +0400
+++ b/arch/x86/kernel/Makefile 2008-04-26 18:22:49.000000000 +0400
@@ -83,7 +83,7 @@
obj-$(CONFIG_VMI) += vmi_32.o vmiclock_32.o
obj-$(CONFIG_PARAVIRT) += paravirt.o paravirt_patch_$(BITS).o
-ifdef CONFIG_INPUT_PCSPKR
+ifdef CONFIG_PCSPKR_PLATFORM
obj-y += pcspeaker.o
endif
--- a/drivers/input/misc/Kconfig 2008-04-22 20:50:41.000000000 +0400
+++ b/drivers/input/misc/Kconfig 2008-04-26 18:23:32.000000000 +0400
@@ -14,7 +14,7 @@
config INPUT_PCSPKR
tristate "PC Speaker support"
- depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+ depends on PCSPKR_PLATFORM
help
Say Y here if you want the standard PC Speaker to be used for
bells and whistles.
next reply other threads:[~2008-05-04 4:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 4:22 Stas Sergeev [this message]
2008-05-05 3:57 ` [patch][resend] pcspkr: fix dependancies Dmitry Torokhov
2008-05-05 4:26 ` Stas Sergeev
2008-05-05 4:35 ` Dmitry Torokhov
2008-05-05 5:02 ` [patch][resend2] " Stas Sergeev
2008-05-05 11:02 ` Takashi Iwai
2008-05-08 17:50 ` [patch] " Stas Sergeev
2008-05-08 13:58 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2008-05-03 11:51 [patch][resend] " Stas Sergeev
2008-05-03 20:01 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481D3A08.2040500@aknet.ru \
--to=stsp@aknet.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael-lists@free-electrons.com \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.