All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@aknet.ru>
To: Takashi Iwai <tiwai@suse.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Linux kernel <linux-kernel@vger.kernel.org>,
	Vojtech Pavlik <vojtech@suse.cz>,
	Michael Opdenacker <michael-lists@free-electrons.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: [patch] pcspkr: fix dependancies
Date: Thu, 08 May 2008 21:50:03 +0400	[thread overview]
Message-ID: <48233D4B.9080505@aknet.ru> (raw)
In-Reply-To: <s5hy76pc8u1.wl%tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

Hello.

Takashi Iwai wrote:
> This could be replaced now better with
>   obj-$(CONFIG_PCSPKR_PLATFORM) += pcspeaker.o
> These two chunks don't apply on 2.6.26-git tree.  Please recreate the
> patch.
Done.
Could you please apply?

---
fix pcspkr dependancies: make the pcspkr platform
drivers to depend on a platform device, and
not the other way around.

Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
CC: Vojtech Pavlik <vojtech@suse.cz>
CC: Michael Opdenacker <michael-lists@free-electrons.com>

[-- Attachment #2: pcsp_dep3.diff --]
[-- Type: text/x-patch, Size: 1728 bytes --]

--- a/init/Kconfig	2008-04-26 13:40:20.000000000 +0400
+++ b/init/Kconfig	2008-04-26 18:20:40.000000000 +0400
@@ -634,6 +634,14 @@
 	help
 	  Enable support for generating core dumps. Disabling saves about 4k.
 
+config PCSPKR_PLATFORM
+	bool "Enable PC-Speaker support" if EMBEDDED
+	depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+	default y
+	help
+          This option allows to disable the internal PC-Speaker
+          support, saving some memory.
+
 config COMPAT_BRK
 	bool "Disable heap randomization"
 	default y
--- a/arch/x86/kernel/Makefile	2008-04-26 13:40:06.000000000 +0400
+++ b/arch/x86/kernel/Makefile	2008-04-26 18:22:49.000000000 +0400
@@ -83,9 +83,7 @@
 obj-$(CONFIG_KVM_CLOCK)		+= kvmclock.o
 obj-$(CONFIG_PARAVIRT)		+= paravirt.o paravirt_patch_$(BITS).o
 
-ifdef CONFIG_INPUT_PCSPKR
-obj-y				+= pcspeaker.o
-endif
+obj-$(CONFIG_PCSPKR_PLATFORM)	+= pcspeaker.o
 
 obj-$(CONFIG_SCx200)		+= scx200.o
 scx200-y			+= scx200_32.o
--- a/sound/drivers/Kconfig	2008-04-26 13:40:21.000000000 +0400
+++ b/sound/drivers/Kconfig	2008-04-26 18:24:59.000000000 +0400
@@ -5,7 +5,8 @@
 
 
 config SND_PCSP
-	tristate "Internal PC speaker support"
+	tristate "PC-Speaker support"
+	depends on PCSPKR_PLATFORM
 	depends on X86_PC && HIGH_RES_TIMERS
 	depends on INPUT
 	depends on SND
--- a/drivers/input/misc/Kconfig	2008-04-22 20:50:41.000000000 +0400
+++ b/drivers/input/misc/Kconfig	2008-04-26 18:23:32.000000000 +0400
@@ -14,7 +14,7 @@
 
 config INPUT_PCSPKR
 	tristate "PC Speaker support"
-	depends on ALPHA || X86 || MIPS || PPC_PREP || PPC_CHRP || PPC_PSERIES
+	depends on PCSPKR_PLATFORM
 	depends on SND_PCSP=n
 	help
 	  Say Y here if you want the standard PC Speaker to be used for

  reply	other threads:[~2008-05-08 14:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04  4:22 [patch][resend] pcspkr: fix dependancies Stas Sergeev
2008-05-05  3:57 ` Dmitry Torokhov
2008-05-05  4:26   ` Stas Sergeev
2008-05-05  4:35     ` Dmitry Torokhov
2008-05-05  5:02       ` [patch][resend2] " Stas Sergeev
2008-05-05 11:02         ` Takashi Iwai
2008-05-08 17:50           ` Stas Sergeev [this message]
2008-05-08 13:58             ` [patch] " Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2008-04-26 15:16 Stas Sergeev
2008-04-26 23:18 ` Dmitry Torokhov
2008-04-26 23:39   ` Stas Sergeev
2008-04-27  4:23     ` Dmitry Torokhov
2008-04-28 19:34       ` Stas Sergeev
2008-04-28 19:58         ` Dmitry Torokhov
2008-04-28 20:12           ` Sam Ravnborg
2008-04-28 20:19             ` Dmitry Torokhov
2008-04-29 19:56             ` Stas Sergeev
2008-04-30  7:31               ` Michael Opdenacker
2008-04-30 11:23                 ` Stas Sergeev
2008-05-01  7:08                 ` Stas Sergeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48233D4B.9080505@aknet.ru \
    --to=stsp@aknet.ru \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael-lists@free-electrons.com \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.