From: Dmitry Torokhov <dtor-oss@comcast.net>
To: Stas Sergeev <stsp@aknet.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Takashi Iwai <tiwai@suse.de>,
Linux kernel <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [patch] pcspkr: fix dependancies
Date: Sat, 26 Apr 2008 19:18:14 -0400 [thread overview]
Message-ID: <200804261918.14711.dtor-oss@comcast.net> (raw)
In-Reply-To: <4813476A.7000705@aknet.ru>
Hi Stas,
On Saturday 26 April 2008, Stas Sergeev wrote:
> Hello.
>
> linux-2.6.25 has the strange dependancies
> for pc-speaker, which prevents snd-pcsp
> from working.
> Namely, the platform device (created in
> arch/x86/kernel/pcspeaker.c) depends on
> the platform driver (CONFIG_INPUT_PCSPKR).
> I wonder if it is a good practice to make
> the platform device to depend on the driver,
> I guess it is not.
>
> The attached patch reverses that.
> It adds the config option for the pcspkr
> platform device and makes the platform
> drivers to depend on that.
> This allows snd-pcsp to work at least in
> some configurations.
>
No, not another config option please. Either make pcspkr platform
device be created unconditionally or if either pcspkr or snd-pcsp
is selected.
--
Dmitry
next prev parent reply other threads:[~2008-04-26 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 15:16 [patch] pcspkr: fix dependancies Stas Sergeev
2008-04-26 23:18 ` Dmitry Torokhov [this message]
2008-04-26 23:39 ` Stas Sergeev
2008-04-27 4:23 ` Dmitry Torokhov
2008-04-28 19:34 ` Stas Sergeev
2008-04-28 19:58 ` Dmitry Torokhov
2008-04-28 20:12 ` Sam Ravnborg
2008-04-28 20:19 ` Dmitry Torokhov
2008-04-29 19:56 ` Stas Sergeev
2008-04-30 7:31 ` Michael Opdenacker
2008-04-30 11:23 ` Stas Sergeev
2008-05-01 7:08 ` Stas Sergeev
-- strict thread matches above, loose matches on Subject: below --
2008-05-04 4:22 [patch][resend] " Stas Sergeev
2008-05-05 3:57 ` Dmitry Torokhov
2008-05-05 4:26 ` Stas Sergeev
2008-05-05 4:35 ` Dmitry Torokhov
2008-05-05 5:02 ` [patch][resend2] " Stas Sergeev
2008-05-05 11:02 ` Takashi Iwai
2008-05-08 17:50 ` [patch] " Stas Sergeev
2008-05-08 13:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804261918.14711.dtor-oss@comcast.net \
--to=dtor-oss@comcast.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
--cc=tiwai@suse.de \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.