From: Neil Turton <nturton@solarflare.com>
To: Espen Skoglund <espen.skoglund@netronome.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] msix: revoke correct amount of msi-x related iomem
Date: Tue, 06 May 2008 17:31:49 +0100 [thread overview]
Message-ID: <482087F5.1030903@solarflare.com> (raw)
In-Reply-To: <18459.22471.351306.107348@gargle.gargle.HOWL>
Espen Skoglund wrote:
> + self.msix_entries = (message_cont_lo + \
> + message_cont_hi << 8) \
> + & MSIX_SIZE_MASK
That still doesn't look right to me since "+" binds tighter than "<<".
I think it needs some more parentheses around "message_cont_hi << 8", at
least if I've understood what the code's supposed to do.
Cheers, Neil.
next prev parent reply other threads:[~2008-05-06 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 18:04 [PATCH] msix: revoke correct amount of msi-x related iomem Espen Skoglund
2008-05-06 16:31 ` Neil Turton [this message]
2008-05-06 16:49 ` Espen Skoglund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482087F5.1030903@solarflare.com \
--to=nturton@solarflare.com \
--cc=espen.skoglund@netronome.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.