From: Mike Travis <travis@sgi.com>
To: Paul Mundt <lethal@linux-sh.org>, Mike Travis <travis@sgi.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
bunk@kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
"David S. Miller" <davem@davemloft.net>,
"William L. Irwin" <wli@holomorphy.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] mm: define default cpu_to_node
Date: Fri, 09 May 2008 15:01:29 +0000 [thread overview]
Message-ID: <48246749.9000101@sgi.com> (raw)
In-Reply-To: <20080509052049.GA2161@linux-sh.org>
Paul Mundt wrote:
> On Thu, May 08, 2008 at 04:02:39PM -0700, Mike Travis wrote:
>> * Some architectures have CONFIG_NUMA=y but do not define a
>> default cpu_to_node macro. This provides the default in
>> asm-generic/topology.h but it relies on the fact that
>> cpu_to_node is a defined macro (and not an inline function).
>>
> NACK.. This isn't going to work anyways, cpu_to_node() is just where the
> first build error occurs. If you do this, then parent_node() is the next
> one to blow up, node_to_cpumask() after that, etc, etc. For now I've just
> stubbed the asm-generic/topology.h definitions in to asm-sh/topology.h.
Ok, Thanks! I was looking at that but without being able to compile it,
it was just a wild swing towards the fence... ;-) And your rationale makes
sense, if an arch really has numa topology then it should define what that is.
Cheers,
Mike
WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Paul Mundt <lethal@linux-sh.org>, Mike Travis <travis@sgi.com>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
bunk@kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
"David S. Miller" <davem@davemloft.net>,
"William L. Irwin" <wli@holomorphy.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/1] mm: define default cpu_to_node
Date: Fri, 09 May 2008 08:01:29 -0700 [thread overview]
Message-ID: <48246749.9000101@sgi.com> (raw)
In-Reply-To: <20080509052049.GA2161@linux-sh.org>
Paul Mundt wrote:
> On Thu, May 08, 2008 at 04:02:39PM -0700, Mike Travis wrote:
>> * Some architectures have CONFIG_NUMA=y but do not define a
>> default cpu_to_node macro. This provides the default in
>> asm-generic/topology.h but it relies on the fact that
>> cpu_to_node is a defined macro (and not an inline function).
>>
> NACK.. This isn't going to work anyways, cpu_to_node() is just where the
> first build error occurs. If you do this, then parent_node() is the next
> one to blow up, node_to_cpumask() after that, etc, etc. For now I've just
> stubbed the asm-generic/topology.h definitions in to asm-sh/topology.h.
Ok, Thanks! I was looking at that but without being able to compile it,
it was just a wild swing towards the fence... ;-) And your rationale makes
sense, if an arch really has numa topology then it should define what that is.
Cheers,
Mike
next prev parent reply other threads:[~2008-05-09 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 23:02 [PATCH 0/1] mm: define default cpu_to_node Mike Travis
2008-05-08 23:02 ` Mike Travis
2008-05-08 23:02 ` [PATCH 1/1] " Mike Travis
2008-05-08 23:02 ` Mike Travis
2008-05-09 5:20 ` Paul Mundt
2008-05-09 5:20 ` Paul Mundt
2008-05-09 15:01 ` Mike Travis [this message]
2008-05-09 15:01 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48246749.9000101@sgi.com \
--to=travis@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=anton@samba.org \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.