diff for duplicates of <48287916.2090203@pobox.com> diff --git a/a/1.txt b/N1/1.txt index 1b1ea26..8b45837 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,13 +9,13 @@ Julia Lawall wrote: >>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int >>> struct net_device *dev = (struct net_device *) dev_id; >>> ->>> if (dev = NULL) { +>>> if (dev == NULL) { >>> - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name); >>> + printk(KERN_ERR "isr: null dev ptr\n"); >>> return IRQ_RETVAL(1); >>> } >> The lifespan of 'dev' covers the request_irq..free_irq interval in this ->> driver. The whole 'dev = NULL' block can be removed. +>> driver. The whole 'dev == NULL' block can be removed. > > Will you do that? diff --git a/a/content_digest b/N1/content_digest index bb16cee..1891efa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0Pine.LNX.4.64.0805121852510.16384@ask.diku.dk\0" "From\0Jeff Garzik <jgarzik@pobox.com>\0" "Subject\0Re: [PATCH 3/6] drivers/net: remove null pointer dereference\0" - "Date\0Mon, 12 May 2008 17:06:30 +0000\0" + "Date\0Mon, 12 May 2008 13:06:30 -0400\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0Francois Romieu <romieu@fr.zoreil.com>" netdev@vger.kernel.org @@ -22,13 +22,13 @@ ">>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int \n" ">>> \tstruct net_device *dev = (struct net_device *) dev_id;\n" ">>> \n" - ">>> \tif (dev = NULL) {\n" + ">>> \tif (dev == NULL) {\n" ">>> -\t\tprintk(KERN_ERR \"%s: isr: null dev ptr\\n\", dev->name);\n" ">>> +\t\tprintk(KERN_ERR \"isr: null dev ptr\\n\");\n" ">>> \t\treturn IRQ_RETVAL(1);\n" ">>> \t}\n" ">> The lifespan of 'dev' covers the request_irq..free_irq interval in this\n" - ">> driver. The whole 'dev = NULL' block can be removed.\n" + ">> driver. The whole 'dev == NULL' block can be removed.\n" "> \n" "> Will you do that?\n" "\n" @@ -38,4 +38,4 @@ "\n" "\tJeff" -748775a6fdd50175b503a563e08d50c2235d2b0bbd709042cf56fe57a775afd6 +cdc188f082909c39760f33d0b135efcaab447d532c27337e74ffa18b492d5b33
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.