From: Jeff Garzik <jgarzik@pobox.com>
To: Julia Lawall <julia@diku.dk>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference
Date: Mon, 12 May 2008 17:06:30 +0000 [thread overview]
Message-ID: <48287916.2090203@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805121852510.16384@ask.diku.dk>
Julia Lawall wrote:
> On Mon, 12 May 2008, Francois Romieu wrote:
>
>> Julia Lawall <julia@diku.dk> :
>> [...]
>>> diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
>>> --- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200
>>> +++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200
>>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int
>>> struct net_device *dev = (struct net_device *) dev_id;
>>>
>>> if (dev = NULL) {
>>> - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
>>> + printk(KERN_ERR "isr: null dev ptr\n");
>>> return IRQ_RETVAL(1);
>>> }
>> The lifespan of 'dev' covers the request_irq..free_irq interval in this
>> driver. The whole 'dev = NULL' block can be removed.
>
> Will you do that?
It's normal within the Linux community to give feedback on patches, and
sometimes the authors need to revise their patches if helpful feedback
arises.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Julia Lawall <julia@diku.dk>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/6] drivers/net: remove null pointer dereference
Date: Mon, 12 May 2008 13:06:30 -0400 [thread overview]
Message-ID: <48287916.2090203@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0805121852510.16384@ask.diku.dk>
Julia Lawall wrote:
> On Mon, 12 May 2008, Francois Romieu wrote:
>
>> Julia Lawall <julia@diku.dk> :
>> [...]
>>> diff -u -p a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
>>> --- a/drivers/net/au1000_eth.c 2008-04-27 11:41:11.000000000 +0200
>>> +++ b/drivers/net/au1000_eth.c 2008-05-12 09:32:54.000000000 +0200
>>> @@ -1242,7 +1242,7 @@ static irqreturn_t au1000_interrupt(int
>>> struct net_device *dev = (struct net_device *) dev_id;
>>>
>>> if (dev == NULL) {
>>> - printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
>>> + printk(KERN_ERR "isr: null dev ptr\n");
>>> return IRQ_RETVAL(1);
>>> }
>> The lifespan of 'dev' covers the request_irq..free_irq interval in this
>> driver. The whole 'dev == NULL' block can be removed.
>
> Will you do that?
It's normal within the Linux community to give feedback on patches, and
sometimes the authors need to revise their patches if helpful feedback
arises.
Jeff
next prev parent reply other threads:[~2008-05-12 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:37 [PATCH 3/6] drivers/net: remove null pointer dereference Julia Lawall
2008-05-12 13:37 ` Julia Lawall
2008-05-12 16:17 ` Francois Romieu
2008-05-12 16:17 ` Francois Romieu
2008-05-12 16:53 ` Julia Lawall
2008-05-12 16:53 ` Julia Lawall
2008-05-12 16:44 ` [PATCH] au1000_eth: remove useless check Francois Romieu
2008-05-12 16:44 ` Francois Romieu
2008-05-22 10:22 ` Jeff Garzik
2008-05-22 10:22 ` Jeff Garzik
2008-05-12 17:06 ` Jeff Garzik [this message]
2008-05-12 17:06 ` [PATCH 3/6] drivers/net: remove null pointer dereference Jeff Garzik
2008-05-12 18:48 ` Julia Lawall
2008-05-12 18:48 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48287916.2090203@pobox.com \
--to=jgarzik@pobox.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.