All of lore.kernel.org
 help / color / mirror / Atom feed
From: David VomLehn <dvomlehn@cisco.com>
To: "Ralf Baechle [ralf"@linux-mips.org]
Cc: linux-mips@linux-mips.org
Subject: Re: [RFC] [PATCH 1/1] [MIPS] Advanced Kernel Stack Backtrace
Date: Mon, 12 May 2008 10:14:20 -0700	[thread overview]
Message-ID: <48287AEC.6090300@cisco.com> (raw)

> On Wed, May 07, 2008 at 04:49:53PM -0700, David VomLehn wrote:
> 
>> This patch contains the kernel stack backtrace code we've been running 
>> for about a year on our MIPS-based settop box. ...

>  o Use ARRAY_SIZE() from <linux/kernel.h> instead of numberof.

Oops, missed this one in the port from 2.6.14 to 2.6.24.

>  o Please run the patch through scripts/checkpatch.pl and fix the resulting
>    errors.

Will do.

>  o Your patch got linewrapped by your mail client.

Ouch. I'll fix that next time.

>   Ralf

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: David VomLehn <dvomlehn@cisco.com>
To: "Ralf Baechle [ralf"@linux-mips.org
Cc: linux-mips@linux-mips.org
Subject: Re: [RFC] [PATCH 1/1] [MIPS] Advanced Kernel Stack Backtrace
Date: Mon, 12 May 2008 10:14:20 -0700	[thread overview]
Message-ID: <48287AEC.6090300@cisco.com> (raw)
Message-ID: <20080512171420.12PZtuJECvetSl1cvQ2hIdkwedjkT5XczwwfP4V7YeE@z> (raw)

> On Wed, May 07, 2008 at 04:49:53PM -0700, David VomLehn wrote:
> 
>> This patch contains the kernel stack backtrace code we've been running 
>> for about a year on our MIPS-based settop box. ...

>  o Use ARRAY_SIZE() from <linux/kernel.h> instead of numberof.

Oops, missed this one in the port from 2.6.14 to 2.6.24.

>  o Please run the patch through scripts/checkpatch.pl and fix the resulting
>    errors.

Will do.

>  o Your patch got linewrapped by your mail client.

Ouch. I'll fix that next time.

>   Ralf

Thanks!

             reply	other threads:[~2008-05-12 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 17:14 David VomLehn [this message]
2008-05-12 17:14 ` [RFC] [PATCH 1/1] [MIPS] Advanced Kernel Stack Backtrace David VomLehn
  -- strict thread matches above, loose matches on Subject: below --
2008-05-07 23:49 David VomLehn
2008-05-11 16:07 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48287AEC.6090300@cisco.com \
    --to=dvomlehn@cisco.com \
    --cc="Ralf Baechle [ralf"@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.