From: Geoff Levand <geoffrey.levand@am.sony.com>
To: akpm@linux-foundation.org
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
mikpe@it.uu.se, Badari Pulavarty <pbadari@us.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: [rfc patch] memory_hotplug: Check for walk_memory_resource() failure in online_pages()
Date: Mon, 12 May 2008 18:13:55 -0700 [thread overview]
Message-ID: <4828EB53.7030407@am.sony.com> (raw)
In-Reply-To: <20080512.174151.193690130.davem@davemloft.net>
Add a check to online_pages() to test for failure of
walk_memory_resource(). This fixes a condition where a failure
of walk_memory_resource() can lead to online_pages() returning
success without the requested pages being onlined.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
I'm not entirely sure this is the proper way to handle this
condition. Comments welcome.
mm/memory_hotplug.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -408,8 +408,15 @@ int online_pages(unsigned long pfn, unsi
if (!populated_zone(zone))
need_zonelists_rebuild = 1;
- walk_memory_resource(pfn, nr_pages, &onlined_pages,
+ ret = walk_memory_resource(pfn, nr_pages, &onlined_pages,
online_pages_range);
+ if (ret) {
+ printk(KERN_DEBUG "online_pages %lx at %lx failed\n",
+ nr_pages, pfn);
+ memory_notify(MEM_CANCEL_ONLINE, &arg);
+ return ret;
+ }
+
zone->present_pages += onlined_pages;
zone->zone_pgdat->node_present_pages += onlined_pages;
WARNING: multiple messages have this Message-ID (diff)
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: akpm@linux-foundation.org
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>,
linuxppc-dev@ozlabs.org, mikpe@it.uu.se,
Badari Pulavarty <pbadari@us.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [rfc patch] memory_hotplug: Check for walk_memory_resource() failure in online_pages()
Date: Mon, 12 May 2008 18:13:55 -0700 [thread overview]
Message-ID: <4828EB53.7030407@am.sony.com> (raw)
In-Reply-To: <20080512.174151.193690130.davem@davemloft.net>
Add a check to online_pages() to test for failure of
walk_memory_resource(). This fixes a condition where a failure
of walk_memory_resource() can lead to online_pages() returning
success without the requested pages being onlined.
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
I'm not entirely sure this is the proper way to handle this
condition. Comments welcome.
mm/memory_hotplug.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -408,8 +408,15 @@ int online_pages(unsigned long pfn, unsi
if (!populated_zone(zone))
need_zonelists_rebuild = 1;
- walk_memory_resource(pfn, nr_pages, &onlined_pages,
+ ret = walk_memory_resource(pfn, nr_pages, &onlined_pages,
online_pages_range);
+ if (ret) {
+ printk(KERN_DEBUG "online_pages %lx at %lx failed\n",
+ nr_pages, pfn);
+ memory_notify(MEM_CANCEL_ONLINE, &arg);
+ return ret;
+ }
+
zone->present_pages += onlined_pages;
zone->zone_pgdat->node_present_pages += onlined_pages;
next prev parent reply other threads:[~2008-05-13 1:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 0:41 [PATCH 0/2]: LMB small bug fix and debugging tidy up David Miller
2008-05-13 0:41 ` David Miller
2008-05-13 1:13 ` Geoff Levand [this message]
2008-05-13 1:13 ` [rfc patch] memory_hotplug: Check for walk_memory_resource() failure in online_pages() Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4828EB53.7030407@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikpe@it.uu.se \
--cc=pbadari@us.ibm.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.