From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-sctp@vger.kernel.org,
lksctp-developers@lists.sourceforge.net,
Wei Yongjun <yjwei@cn.fujitsu.com>
Subject: Re: [PATCH] [SCTP]: Add address type check while process paramaters
Date: Tue, 13 May 2008 12:48:39 +0000 [thread overview]
Message-ID: <48298E27.40100@hp.com> (raw)
In-Reply-To: <48297BE9.9020204@trash.net>
Patrick McHardy wrote:
> Vlad Yasevich wrote:
>> @@ -2827,6 +2827,19 @@ static __be16 sctp_process_asconf_param(struct
>> sctp_association *asoc,
>> union sctp_addr addr;
>> union sctp_addr_param *addr_param;
>>
>> + switch (addr_param->v4.param_hdr.type) {
>
> ^^^ use of addr_param
>
>> + case SCTP_PARAM_IPV6_ADDRESS:
>> + if (!asoc->peer.ipv6_address)
>> + return SCTP_ERROR_INV_PARAM;
>> + break;
>> + case SCTP_PARAM_IPV4_ADDRESS:
>> + if (!asoc->peer.ipv4_address)
>> + return SCTP_ERROR_INV_PARAM;
>> + break;
>> + default:
>> + return SCTP_ERROR_INV_PARAM;
>> + }
>> +
>> addr_param = (union sctp_addr_param *)
>> ((void *)asconf_param + sizeof(sctp_addip_param_t));
>
> ^^^ initialization of addr_param
>
> The patch is wrong and needs this fix on top.
>
Ack. David, please apply. I missed this warning in the my builds...
Thanks
-vlad
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-sctp@vger.kernel.org,
lksctp-developers@lists.sourceforge.net,
Wei Yongjun <yjwei@cn.fujitsu.com>
Subject: Re: [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk
Date: Tue, 13 May 2008 08:48:39 -0400 [thread overview]
Message-ID: <48298E27.40100@hp.com> (raw)
In-Reply-To: <48297BE9.9020204@trash.net>
Patrick McHardy wrote:
> Vlad Yasevich wrote:
>> @@ -2827,6 +2827,19 @@ static __be16 sctp_process_asconf_param(struct
>> sctp_association *asoc,
>> union sctp_addr addr;
>> union sctp_addr_param *addr_param;
>>
>> + switch (addr_param->v4.param_hdr.type) {
>
> ^^^ use of addr_param
>
>> + case SCTP_PARAM_IPV6_ADDRESS:
>> + if (!asoc->peer.ipv6_address)
>> + return SCTP_ERROR_INV_PARAM;
>> + break;
>> + case SCTP_PARAM_IPV4_ADDRESS:
>> + if (!asoc->peer.ipv4_address)
>> + return SCTP_ERROR_INV_PARAM;
>> + break;
>> + default:
>> + return SCTP_ERROR_INV_PARAM;
>> + }
>> +
>> addr_param = (union sctp_addr_param *)
>> ((void *)asconf_param + sizeof(sctp_addip_param_t));
>
> ^^^ initialization of addr_param
>
> The patch is wrong and needs this fix on top.
>
Ack. David, please apply. I missed this warning in the my builds...
Thanks
-vlad
next prev parent reply other threads:[~2008-05-13 12:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 19:09 [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket Vlad Yasevich
2008-05-09 19:09 ` Vlad Yasevich
2008-05-09 19:09 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Vlad Yasevich
2008-05-09 19:09 ` Vlad Yasevich
2008-05-09 22:12 ` [PATCH] [SCTP]: Add address type check while process David Miller
2008-05-09 22:12 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk David Miller
2008-05-13 11:30 ` [PATCH] [SCTP]: Add address type check while process paramaters Patrick McHardy
2008-05-13 11:30 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Patrick McHardy
2008-05-13 12:48 ` Vlad Yasevich [this message]
2008-05-13 12:48 ` Vlad Yasevich
2008-05-13 22:32 ` [PATCH] [SCTP]: Add address type check while process David Miller
2008-05-13 22:32 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk David Miller
2008-05-14 0:56 ` [PATCH] [SCTP]: Add address type check while process paramaters Wei Yongjun
2008-05-14 0:56 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Wei Yongjun
2008-05-14 1:14 ` [PATCH] [SCTP]: Add address type check while process David Miller
2008-05-14 1:14 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk David Miller
2008-05-14 1:49 ` [PATCH] [SCTP]: Add address type check while process paramaters Wei Yongjun
2008-05-14 1:49 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk Wei Yongjun
2008-05-14 6:25 ` [PATCH] [SCTP]: Add address type check while process David Miller
2008-05-14 6:25 ` [PATCH] [SCTP]: Add address type check while process paramaters of ASCONF chunk David Miller
2008-05-09 22:11 ` [PATCH] [SCTP]: Do not enable peer IPv6 address support on David Miller
2008-05-09 22:11 ` [PATCH] [SCTP]: Do not enable peer IPv6 address support on PF_INET socket David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48298E27.40100@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.