From: Rene Herman <rene.herman@keyaccess.nl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: ALSA devel <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Glauber Costa <gcosta@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Pete Clements <clem@clem.clem-digital.net>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected)
Date: Tue, 13 May 2008 19:33:25 +0200 [thread overview]
Message-ID: <4829D0E5.8050905@keyaccess.nl> (raw)
In-Reply-To: <20080513180107.1a3893f1@core>
On 13-05-08 19:01, Alan Cox wrote:
> On Tue, 13 May 2008 10:59:32 -0600
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
>> On Friday 09 May 2008 12:06:55 am Takashi Iwai wrote:
>>> Thanks for catching it. Yeah, the patch looks buggy. We had an
>>> implicit assumption that dev = NULL for ISA devices that require 24bit
>>> DMA.
>> Naive question #1: Why don't we have a struct device for these
>> ISA devices? PNP builds a struct device with DMA_24BIT_MASK
>> for ISAPNP devices.
>
> Because nobody has done the needed work to get all the old ISA drivers
> converted. I guess isa_device would actually be a platform_device
> wrapper ?
No, isa_device is its own thing, on its own isa_bus (*). It has a struct
device * readily available though...
Rene
(*) drivers/base/isa.c, and explanatory changelog at:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5117ba7da37deb09df5eb802dace229b3fb1e9f
WARNING: multiple messages have this Message-ID (diff)
From: Rene Herman <rene.herman@keyaccess.nl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Takashi Iwai <tiwai@suse.de>, Glauber Costa <gcosta@redhat.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Pete Clements <clem@clem.clem-digital.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
ALSA devel <alsa-devel@alsa-project.org>
Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected)
Date: Tue, 13 May 2008 19:33:25 +0200 [thread overview]
Message-ID: <4829D0E5.8050905@keyaccess.nl> (raw)
In-Reply-To: <20080513180107.1a3893f1@core>
On 13-05-08 19:01, Alan Cox wrote:
> On Tue, 13 May 2008 10:59:32 -0600
> Bjorn Helgaas <bjorn.helgaas@hp.com> wrote:
>
>> On Friday 09 May 2008 12:06:55 am Takashi Iwai wrote:
>>> Thanks for catching it. Yeah, the patch looks buggy. We had an
>>> implicit assumption that dev = NULL for ISA devices that require 24bit
>>> DMA.
>> Naive question #1: Why don't we have a struct device for these
>> ISA devices? PNP builds a struct device with DMA_24BIT_MASK
>> for ISAPNP devices.
>
> Because nobody has done the needed work to get all the old ISA drivers
> converted. I guess isa_device would actually be a platform_device
> wrapper ?
No, isa_device is its own thing, on its own isa_bus (*). It has a struct
device * readily available though...
Rene
(*) drivers/base/isa.c, and explanatory changelog at:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=a5117ba7da37deb09df5eb802dace229b3fb1e9f
next prev parent reply other threads:[~2008-05-13 17:32 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-09 1:37 2.6.26-rc1 regression: ISA DMA broken (bisected) Rene Herman
2008-05-09 1:37 ` Rene Herman
2008-05-09 6:06 ` Takashi Iwai
2008-05-09 6:06 ` Takashi Iwai
2008-05-09 8:55 ` Ingo Molnar
2008-05-09 8:55 ` Ingo Molnar
2008-05-09 8:58 ` Ingo Molnar
2008-05-09 17:20 ` Jesse Barnes
2008-05-09 12:03 ` Rene Herman
2008-05-09 12:03 ` Rene Herman
2008-05-09 12:28 ` Ingo Molnar
2008-05-09 12:28 ` Ingo Molnar
2008-05-09 23:00 ` Rene Herman
2008-05-09 23:00 ` Rene Herman
2008-05-13 14:36 ` Ingo Molnar
2008-05-13 14:36 ` Ingo Molnar
2008-05-13 15:26 ` Rene Herman
2008-05-09 12:29 ` Pete Clements
2008-05-09 12:29 ` Pete Clements
2008-05-09 12:48 ` Glauber Costa
2008-05-13 16:59 ` Bjorn Helgaas
2008-05-13 16:59 ` Bjorn Helgaas
2008-05-13 17:01 ` Alan Cox
2008-05-13 17:01 ` Alan Cox
2008-05-13 17:33 ` Rene Herman [this message]
2008-05-13 17:33 ` Rene Herman
2008-05-13 23:18 ` Bjorn Helgaas
2008-05-13 23:18 ` Bjorn Helgaas
2008-05-14 9:25 ` Takashi Iwai
2008-05-14 9:25 ` Takashi Iwai
2008-05-14 12:46 ` Rene Herman
2008-05-14 12:46 ` Rene Herman
2008-05-14 13:01 ` Takashi Iwai
2008-05-14 15:40 ` Rene Herman
2008-05-14 15:40 ` Rene Herman
2008-05-14 15:53 ` Takashi Iwai
2008-05-14 15:53 ` Takashi Iwai
2008-05-14 18:41 ` Rene Herman
2008-05-14 18:50 ` Bjorn Helgaas
2008-05-14 19:09 ` Rene Herman
2008-05-14 19:09 ` Rene Herman
2008-05-30 21:15 ` [PATCH] " Rene Herman
2008-05-30 21:15 ` Rene Herman
2008-05-30 21:28 ` [DEVICE MODEL] dev->dma_mask Rene Herman
2008-05-30 21:28 ` Rene Herman
2008-05-30 21:43 ` [PATCH] Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) Bjorn Helgaas
2008-05-30 21:43 ` Bjorn Helgaas
2008-05-30 22:11 ` Rene Herman
2008-05-30 22:11 ` Rene Herman
2008-05-30 22:37 ` [PATCH] ISA: set 24-bit dma_mask for ISA devices Rene Herman
2008-05-30 22:37 ` Rene Herman
2008-05-30 22:55 ` Andrew Morton
2008-05-30 22:55 ` Andrew Morton
2008-05-30 23:50 ` Rene Herman
2008-05-30 23:50 ` Rene Herman
2008-05-30 23:54 ` [PATCH] PNP: set the pnp_card dma_mask for use by ISAPnP cards Rene Herman
2008-05-30 23:54 ` Rene Herman
2008-05-31 8:55 ` Takashi Iwai
2008-05-31 8:55 ` Takashi Iwai
2008-05-30 23:55 ` [PATCH] ISA: set 24-bit dma_mask for ISA devices Rene Herman
2008-05-30 23:55 ` Rene Herman
2008-05-31 8:56 ` Takashi Iwai
2008-05-31 8:56 ` Takashi Iwai
2008-05-14 15:26 ` 2.6.26-rc1 regression: ISA DMA broken (bisected) Bjorn Helgaas
2008-05-14 15:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4829D0E5.8050905@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.helgaas@hp.com \
--cc=clem@clem.clem-digital.net \
--cc=gcosta@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.