From: "H. Peter Anvin" <hpa@zytor.com>
To: Joe Perches <joe@perches.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Miklos Vajna <vmiklos@frugalware.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/3] x86: janitor work in bugs.c
Date: Tue, 13 May 2008 21:44:27 -0700 [thread overview]
Message-ID: <482A6E2B.4030806@zytor.com> (raw)
In-Reply-To: <1210724499.14967.78.camel@localhost>
Joe Perches wrote:
> On Tue, 2008-05-13 at 23:09 +0200, Andi Kleen wrote:
>> We had a discussion recently that wrapping printk format strings
>> is a bad idea. Don't do it please.
>
> I don't know that there was a resolution either.
> http://lkml.org/lkml/2008/2/22/143
>
> If there was one, there's a lot of possible changes.
>
> $ grep -rP --include=*.[ch] "printk.*\"\s*$\s*\"" * | wc -l
> 13276
>
> divide by 2, there are more than 6K split source line printks
>
Perhaps a better idea would be to write a script to grep for strings.
-hpa
next prev parent reply other threads:[~2008-05-14 4:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 11:35 [PATCH 1/3] x86: janitor work in video-vga.c Miklos Vajna
2008-05-13 11:35 ` [PATCH 2/3] x86: janitor work in bugs.c Miklos Vajna
2008-05-13 12:44 ` Ingo Molnar
2008-05-13 16:11 ` [PATCH] " Miklos Vajna
2008-05-16 13:48 ` Ingo Molnar
2008-05-17 20:48 ` Miklos Vajna
2008-05-13 21:09 ` [PATCH 2/3] " Andi Kleen
2008-05-13 21:44 ` Miklos Vajna
2008-05-14 0:21 ` Joe Perches
2008-05-14 4:44 ` H. Peter Anvin [this message]
2008-05-13 11:35 ` [PATCH 3/3] x86: janitor work in irq.c Miklos Vajna
2008-05-13 12:46 ` Ingo Molnar
2008-05-13 16:38 ` [PATCH] " Miklos Vajna
2008-05-16 17:28 ` Jesse Barnes
2008-05-13 12:42 ` [PATCH 1/3] x86: janitor work in video-vga.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482A6E2B.4030806@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.