From: Andi Kleen <andi@firstfloor.org>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/3] x86: janitor work in bugs.c
Date: Tue, 13 May 2008 23:09:24 +0200 [thread overview]
Message-ID: <87tzh17vy3.fsf@basil.nowhere.org> (raw)
In-Reply-To: <fe3003f39869f8773950d23bb73efe42b5cf07a5.1210678238.git.vmiklos@frugalware.org> (Miklos Vajna's message of "Tue, 13 May 2008 13:35:26 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> if (!boot_cpu_data.hard_math) {
> #ifndef CONFIG_MATH_EMULATION
> - printk(KERN_EMERG "No coprocessor found and no math emulation present.\n");
> + printk(KERN_EMERG "No coprocessor found and no math "
> + "emulation present.\n");
This means if someone gets this message and wants to grep for it they won't
find it. Bad bad bad.
We had a discussion recently that wrapping printk format strings
is a bad idea. Don't do it please.
-Andi
next prev parent reply other threads:[~2008-05-13 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 11:35 [PATCH 1/3] x86: janitor work in video-vga.c Miklos Vajna
2008-05-13 11:35 ` [PATCH 2/3] x86: janitor work in bugs.c Miklos Vajna
2008-05-13 12:44 ` Ingo Molnar
2008-05-13 16:11 ` [PATCH] " Miklos Vajna
2008-05-16 13:48 ` Ingo Molnar
2008-05-17 20:48 ` Miklos Vajna
2008-05-13 21:09 ` Andi Kleen [this message]
2008-05-13 21:44 ` [PATCH 2/3] " Miklos Vajna
2008-05-14 0:21 ` Joe Perches
2008-05-14 4:44 ` H. Peter Anvin
2008-05-13 11:35 ` [PATCH 3/3] x86: janitor work in irq.c Miklos Vajna
2008-05-13 12:46 ` Ingo Molnar
2008-05-13 16:38 ` [PATCH] " Miklos Vajna
2008-05-16 17:28 ` Jesse Barnes
2008-05-13 12:42 ` [PATCH 1/3] x86: janitor work in video-vga.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzh17vy3.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.