All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@seznam.cz>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	rth@twiddle.net, linux-ia64@vger.kernel.org, tony.luck@intel.com
Subject: Re: Locking API testsuite problem - Microblaze
Date: Sat, 17 May 2008 19:23:12 +0000	[thread overview]
Message-ID: <482F30A0.4090203@seznam.cz> (raw)
In-Reply-To: <20080517073032.GA2638@parisc-linux.org>

Hi Matthew,

> On Sat, May 17, 2008 at 09:07:36AM +0200, Michal Simek wrote:
>> Hi Richard, Tony, Arnd and others,
>>
>> I turn on API testsuite for Microblaze CPU for stable 2.6.24 and I got nice log
>> with some faults. The same problem I have on latest version.
>>
>> I found the similar problem for alpha CPU and ia64 but I haven't found solving
>> these issues. Could you give me a hint how to solve this problem.
> 
> You missed the crucial line:

oou.

> 143 out of 218 testcases failed, as expected.
> 
> Some of these testcases are /expected/ to fail.  Succeeding would be an
> bug.  There are no bugs here.

Thanks for your help. Are these tescases architecture dependent? Because I saw
some logs from other arch and they have everything OK.

Does it mean that everything what I supported works well?

I look to source code and I found these two lines.

DO_TESTCASE_6("double unlock", double_unlock);
DO_TESTCASE_6("initialize held", init_held);

and macro

#define DO_TESTCASE_6(desc, name)                               \
         print_testname(desc);                                   \
         dotest(name##_spin, FAILURE, LOCKTYPE_SPIN);            \
         dotest(name##_wlock, FAILURE, LOCKTYPE_RWLOCK);         \
         dotest(name##_rlock, FAILURE, LOCKTYPE_RWLOCK);         \
         dotest(name##_mutex, FAILURE, LOCKTYPE_MUTEX);          \
         dotest(name##_wsem, FAILURE, LOCKTYPE_RWSEM);           \
         dotest(name##_rsem, FAILURE, LOCKTYPE_RWSEM);           \
         printk("\n");

My results
                             | spin |wlock |rlock |mutex | wsem | rsem |
                double unlock:  ok  |  ok  |failed|failed|failed|failed|
              initialize held:failed|failed|failed|failed|failed|failed|

Is this result OK? Because macro say that expected value is failed.

Regards,
Michal


WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@seznam.cz>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	rth@twiddle.net, linux-ia64@vger.kernel.org, tony.luck@intel.com
Subject: Re: Locking API testsuite problem - Microblaze
Date: Sat, 17 May 2008 21:23:12 +0200	[thread overview]
Message-ID: <482F30A0.4090203@seznam.cz> (raw)
In-Reply-To: <20080517073032.GA2638@parisc-linux.org>

Hi Matthew,

> On Sat, May 17, 2008 at 09:07:36AM +0200, Michal Simek wrote:
>> Hi Richard, Tony, Arnd and others,
>>
>> I turn on API testsuite for Microblaze CPU for stable 2.6.24 and I got nice log
>> with some faults. The same problem I have on latest version.
>>
>> I found the similar problem for alpha CPU and ia64 but I haven't found solving
>> these issues. Could you give me a hint how to solve this problem.
> 
> You missed the crucial line:

oou.

> 143 out of 218 testcases failed, as expected.
> 
> Some of these testcases are /expected/ to fail.  Succeeding would be an
> bug.  There are no bugs here.

Thanks for your help. Are these tescases architecture dependent? Because I saw
some logs from other arch and they have everything OK.

Does it mean that everything what I supported works well?

I look to source code and I found these two lines.

DO_TESTCASE_6("double unlock", double_unlock);
DO_TESTCASE_6("initialize held", init_held);

and macro

#define DO_TESTCASE_6(desc, name)                               \
         print_testname(desc);                                   \
         dotest(name##_spin, FAILURE, LOCKTYPE_SPIN);            \
         dotest(name##_wlock, FAILURE, LOCKTYPE_RWLOCK);         \
         dotest(name##_rlock, FAILURE, LOCKTYPE_RWLOCK);         \
         dotest(name##_mutex, FAILURE, LOCKTYPE_MUTEX);          \
         dotest(name##_wsem, FAILURE, LOCKTYPE_RWSEM);           \
         dotest(name##_rsem, FAILURE, LOCKTYPE_RWSEM);           \
         printk("\n");

My results
                             | spin |wlock |rlock |mutex | wsem | rsem |
                double unlock:  ok  |  ok  |failed|failed|failed|failed|
              initialize held:failed|failed|failed|failed|failed|failed|

Is this result OK? Because macro say that expected value is failed.

Regards,
Michal


  reply	other threads:[~2008-05-17 19:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-17  7:07 Locking API testsuite problem - Microblaze Michal Simek
2008-05-17  7:07 ` Michal Simek
2008-05-17  7:30 ` Matthew Wilcox
2008-05-17  7:30   ` Matthew Wilcox
2008-05-17 19:23   ` Michal Simek [this message]
2008-05-17 19:23     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482F30A0.4090203@seznam.cz \
    --to=monstr@seznam.cz \
    --cc=arnd@arndb.de \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=rth@twiddle.net \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.