From: Stas Sergeev <stsp@aknet.ru>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>,
Roberto Oppedisano <roberto.oppedisano@infracom.it>
Subject: Re: [patch] snd-pcsp: silent misleading warning
Date: Sun, 18 May 2008 21:32:39 +0400 [thread overview]
Message-ID: <48306837.7030505@aknet.ru> (raw)
In-Reply-To: <s5hskwgkqe1.wl%tiwai@suse.de>
Hello.
Takashi Iwai wrote:
>>> [ 417.338143] PCSP: playback_ptr inconsistent (4642 4661 18645)
>> It turns out that the buffer size you
>> get, is not evenly devided by period size.
>> 18645 % 4661 = 1.
>> That (wrongly) triggers the warning.
>> This may very well be an alsa bug, or
>> may not, but the code in the driver is
>> handling that properly, so there is no
>> need for such a verbose warning.
> The right fix would be to add a hw_constraint to align the buffer
> size. The simplest way is to add the following in PCM open callback.
But what does this fix? That's only a
warning, the driver itself doesn't care
at all. The fix you propose, will need
more testing, at least a confirmation
from the reporter. I simply thought this
can't happen. Now you say its a perfectly
sane situation, and then there is nothing
to care about, just shut up the warning.
No?
WARNING: multiple messages have this Message-ID (diff)
From: Stas Sergeev <stsp@aknet.ru>
To: Takashi Iwai <tiwai@suse.de>
Cc: Roberto Oppedisano <roberto.oppedisano@infracom.it>,
LKML <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org
Subject: Re: [patch] snd-pcsp: silent misleading warning
Date: Sun, 18 May 2008 21:32:39 +0400 [thread overview]
Message-ID: <48306837.7030505@aknet.ru> (raw)
In-Reply-To: <s5hskwgkqe1.wl%tiwai@suse.de>
Hello.
Takashi Iwai wrote:
>>> [ 417.338143] PCSP: playback_ptr inconsistent (4642 4661 18645)
>> It turns out that the buffer size you
>> get, is not evenly devided by period size.
>> 18645 % 4661 = 1.
>> That (wrongly) triggers the warning.
>> This may very well be an alsa bug, or
>> may not, but the code in the driver is
>> handling that properly, so there is no
>> need for such a verbose warning.
> The right fix would be to add a hw_constraint to align the buffer
> size. The simplest way is to add the following in PCM open callback.
But what does this fix? That's only a
warning, the driver itself doesn't care
at all. The fix you propose, will need
more testing, at least a confirmation
from the reporter. I simply thought this
can't happen. Now you say its a perfectly
sane situation, and then there is nothing
to care about, just shut up the warning.
No?
next prev parent reply other threads:[~2008-05-18 13:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-11 18:15 2.6.26-rc1 regression: e5e1d3cb20034a3cbcfff1f0bae12201aa2ce17e breaks artsd Roberto Oppedisano
2008-05-11 18:56 ` Stas Sergeev
2008-05-11 20:28 ` Roberto Oppedisano
2008-05-11 20:56 ` Stas Sergeev
2008-05-12 7:24 ` Roberto Oppedisano
2008-05-12 18:22 ` Stas Sergeev
2008-05-13 14:00 ` Roberto Oppedisano
2008-05-13 15:41 ` Roberto Oppedisano
2008-05-13 16:50 ` Non-working snd-pcsp Takashi Iwai
2008-05-14 5:35 ` Roberto Oppedisano
2008-05-14 10:03 ` Takashi Iwai
2008-05-15 20:17 ` Roberto Oppedisano
2008-05-15 20:38 ` Stas Sergeev
2008-05-16 13:15 ` Jan Engelhardt
2008-05-16 13:40 ` Takashi Iwai
2008-05-16 15:18 ` Jan Engelhardt
2008-05-16 15:23 ` Takashi Iwai
2008-05-16 15:24 ` Rene Herman
2008-05-19 18:10 ` Stas Sergeev
2008-05-17 12:02 ` Non-working snd-pcsp - solved Roberto Oppedisano
2008-05-17 15:50 ` [patch] snd-pcsp: silent misleading warning Stas Sergeev
2008-05-17 15:50 ` Stas Sergeev
2008-05-18 7:44 ` Takashi Iwai
2008-05-18 7:44 ` Takashi Iwai
2008-05-18 17:32 ` Stas Sergeev [this message]
2008-05-18 17:32 ` Stas Sergeev
2008-05-18 16:28 ` Takashi Iwai
2008-05-18 16:28 ` Takashi Iwai
2008-05-18 16:49 ` Stas Sergeev
2008-05-18 16:49 ` Stas Sergeev
2008-05-14 19:59 ` Non-working snd-pcsp Stas Sergeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48306837.7030505@aknet.ru \
--to=stsp@aknet.ru \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roberto.oppedisano@infracom.it \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.