All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] always set a/c/mtime through ->setattr
Date: Tue, 20 May 2008 09:19:18 +0300	[thread overview]
Message-ID: <48326D66.8000106@nokia.com> (raw)
In-Reply-To: <20080520060838.GA6436@lst.de>

Christoph,

Christoph Hellwig wrote:
> Currently touch_atime and file_update_time directly update a/c/mtime
> in the inode and just mark the inode dirty afterwards.  This is pretty
> bad for some more complex filesystems that have various different types
> of dirtying an inode and/or need to store the data in another place
> for example for a buffer to be logged.
> 
> This patch changes touch_atime and file_update_time to not update the
> inode directly but rather call through ->setattr into the filessystem.

This patch would make our (UBIFS develpers') life easier, thank you!

Could we go a further and allow the file-system returning error if it
for some reasons cannot change the time? For example, the FS could
return -EIO or -ENOSPC up and VFS would have to free resources and
propagate this error to user-space. Is this possible?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] always set a/c/mtime through ->setattr
Date: Tue, 20 May 2008 09:19:18 +0300	[thread overview]
Message-ID: <48326D66.8000106@nokia.com> (raw)
In-Reply-To: <20080520060838.GA6436@lst.de>

Christoph,

Christoph Hellwig wrote:
> Currently touch_atime and file_update_time directly update a/c/mtime
> in the inode and just mark the inode dirty afterwards.  This is pretty
> bad for some more complex filesystems that have various different types
> of dirtying an inode and/or need to store the data in another place
> for example for a buffer to be logged.
> 
> This patch changes touch_atime and file_update_time to not update the
> inode directly but rather call through ->setattr into the filessystem.

This patch would make our (UBIFS develpers') life easier, thank you!

Could we go a further and allow the file-system returning error if it
for some reasons cannot change the time? For example, the FS could
return -EIO or -ENOSPC up and VFS would have to free resources and
propagate this error to user-space. Is this possible?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-05-20  6:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-20  6:08 [PATCH] always set a/c/mtime through ->setattr Christoph Hellwig
2008-05-20  6:19 ` Artem Bityutskiy [this message]
2008-05-20  6:19   ` Artem Bityutskiy
2008-05-20  6:28   ` Christoph Hellwig
2008-05-20  7:40 ` Miklos Szeredi
2008-05-20  8:33   ` Christoph Hellwig
2008-05-22 18:10     ` Miklos Szeredi
2008-05-22 18:10       ` Miklos Szeredi
2008-05-31 13:20       ` Al Viro
2008-05-31 13:24         ` Christoph Hellwig
2008-05-31 13:35           ` Al Viro
2008-05-21  6:58 ` [PATCH 2/2] " Christoph Hellwig
2008-05-21 17:19   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48326D66.8000106@nokia.com \
    --to=artem.bityutskiy@nokia.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.