* [VLAN]: Correctly handle device notifications for layered VLAN devices
@ 2008-05-20 13:23 Patrick McHardy
2008-05-20 13:25 ` Pavel Emelyanov
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2008-05-20 13:23 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List, Pavel Emelyanov
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 992 bytes --]
commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a
Author: Patrick McHardy <kaber@trash.net>
Date: Tue May 20 15:12:49 2008 +0200
[VLAN]: Correctly handle device notifications for layered VLAN devices
Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing)
changed the device notifier to special-case notifications for VLAN
devices, effectively disabling state propagation to underlying VLAN
devices. This is needed for layered VLANs though, so restore the
original behaviour.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 2a739ad..b934159 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -410,10 +410,8 @@ static int vlan_device_event(struct notifier_block *unused, unsigned long event,
int i, flgs;
struct net_device *vlandev;
- if (is_vlan_dev(dev)) {
+ if (is_vlan_dev(dev))
__vlan_device_event(dev, event);
- goto out;
- }
grp = __vlan_find_group(dev);
if (!grp)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [VLAN]: Correctly handle device notifications for layered VLAN devices
2008-05-20 13:23 [VLAN]: Correctly handle device notifications for layered VLAN devices Patrick McHardy
@ 2008-05-20 13:25 ` Pavel Emelyanov
2008-05-20 21:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Emelyanov @ 2008-05-20 13:25 UTC (permalink / raw)
To: Patrick McHardy, David S. Miller; +Cc: Linux Netdev List
Patrick McHardy wrote:
> commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a
> Author: Patrick McHardy <kaber@trash.net>
> Date: Tue May 20 15:12:49 2008 +0200
>
> [VLAN]: Correctly handle device notifications for layered VLAN devices
>
> Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing)
> changed the device notifier to special-case notifications for VLAN
> devices, effectively disabling state propagation to underlying VLAN
> devices. This is needed for layered VLANs though, so restore the
> original behaviour.
>
> Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Pavel Emelyanov <xemul@openvz.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [VLAN]: Correctly handle device notifications for layered VLAN devices
2008-05-20 13:25 ` Pavel Emelyanov
@ 2008-05-20 21:38 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2008-05-20 21:38 UTC (permalink / raw)
To: xemul; +Cc: kaber, netdev
From: Pavel Emelyanov <xemul@openvz.org>
Date: Tue, 20 May 2008 17:25:47 +0400
> Patrick McHardy wrote:
> > commit cf794e6af782a838252dfc9fc6f10f7a7f66f62a
> > Author: Patrick McHardy <kaber@trash.net>
> > Date: Tue May 20 15:12:49 2008 +0200
> >
> > [VLAN]: Correctly handle device notifications for layered VLAN devices
> >
> > Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing)
> > changed the device notifier to special-case notifications for VLAN
> > devices, effectively disabling state propagation to underlying VLAN
> > devices. This is needed for layered VLANs though, so restore the
> > original behaviour.
> >
> > Signed-off-by: Patrick McHardy <kaber@trash.net>
>
> Acked-by: Pavel Emelyanov <xemul@openvz.org>
Applied and I'll queue up to -stable if relevant...
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-20 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-20 13:23 [VLAN]: Correctly handle device notifications for layered VLAN devices Patrick McHardy
2008-05-20 13:25 ` Pavel Emelyanov
2008-05-20 21:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.