All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhigang Wang <zhigang.x.wang@oracle.com>
To: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH]Remove XendLogging dependency from xswatch
Date: Wed, 21 May 2008 13:36:11 +0800	[thread overview]
Message-ID: <4833B4CB.3090001@oracle.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Hi,

xstransact and xswatch are well designed python interface that can be used by
third party utils rather than only in xend. But the logging approach here binds
xswatch to xend and prevent it from being used by other utils.

This patch removes the dependency on XendLogging from xswatch.

Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

regards,

zhigang

[-- Attachment #2: xen-xswatch-logging.patch --]
[-- Type: text/x-patch, Size: 1097 bytes --]

Remove XendLogging dependency from xswatch

xstransact and xswatch are well designed python interface that can be used by
third party utils rather than only in xend. But the logging approach here binds
xswatch to xend and prevent it from being used by other utils. 

This patch removes the dependency on XendLogging from xswatch.

Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

--- xen-unstable.orig/tools/python/xen/xend/xenstore/xswatch.py	2008-05-12 16:43:52.000000000 +0800
+++ xen-unstable/tools/python/xen/xend/xenstore/xswatch.py	2008-05-21 13:14:58.000000000 +0800
@@ -9,8 +9,6 @@ import errno
 import threading
 from xen.xend.xenstore.xsutil import xshandle
 
-from xen.xend.XendLogging import log
-
 
 class xswatch:
 
@@ -76,7 +74,7 @@ def watchMain():
                     else:
                         raise
         except:
-            log.exception("read_watch failed")
+            pass
             # Ignore this exception -- there's no point throwing it
             # further on because that will just kill the watcher thread,
             # which achieves nothing.

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2008-05-21  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  5:36 Zhigang Wang [this message]
2008-05-21 13:10 ` [PATCH]Remove XendLogging dependency from xswatch Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4833B4CB.3090001@oracle.com \
    --to=zhigang.x.wang@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.