All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Zhigang Wang <zhigang.x.wang@oracle.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]Remove XendLogging dependency from xswatch
Date: Wed, 21 May 2008 14:10:13 +0100	[thread overview]
Message-ID: <20080521131013.GB3915@redhat.com> (raw)
In-Reply-To: <4833B4CB.3090001@oracle.com>

On Wed, May 21, 2008 at 01:36:11PM +0800, Zhigang Wang wrote:
> Hi,
> 
> xstransact and xswatch are well designed python interface that can be used by
> third party utils rather than only in xend. But the logging approach here binds
> xswatch to xend and prevent it from being used by other utils.
> 
> This patch removes the dependency on XendLogging from xswatch.

Instead of doing

   from xen.xend.XendLogging import log

   ...

   log.debug("Blah")


All the code could  just use Python's real logging API directly avoiding
the Xen specific code which doesn't really add any value here. eg

    import logging

    logging.debug("Blah")

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

      reply	other threads:[~2008-05-21 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21  5:36 [PATCH]Remove XendLogging dependency from xswatch Zhigang Wang
2008-05-21 13:10 ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080521131013.GB3915@redhat.com \
    --to=berrange@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=zhigang.x.wang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.