All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Scott Wood <scottwood@freescale.com>
Cc: Anton Vorontsov <avorontsov@ru.mvista.com>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	"Kernel, Linux" <linux-kernel@vger.kernel.org>,
	Kumar Gala <galak@kernel.crashing.org>,
	Linux I2C <i2c@lm-sensors.org>, Jean Delvare <khali@linux-fr.org>,
	Paul Mackerras <paulus@samba.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] [POWERPC] Add i2c pins to dts and board setup
Date: Wed, 21 May 2008 18:17:06 +0200	[thread overview]
Message-ID: <48344B02.7070308@scram.de> (raw)
In-Reply-To: <20080521151003.GA13858@ld0162-tx32.am.freescale.net>

Hi Scott,

>> +   - linux,i2c-index : Can be used to hard code an i2c bus number.
>> +   - linux,i2c-class : Can be used to override the i2c class.
>
> Why do we need this?

There are still a bunch of i2c drivers using the old API (mainly v4l and dvb stuff)
which are slowly being converted by their subsystem maintainers, though.

> It'd be better to just convert any needed old-style drivers than add this
> to the device tree.

Sure. That's why the parameters are only optional. Once all i2c drivers are
converted, these parameters won't be used anymore. Maybe they should be marked
as deprecated.

>> +   - bus-frequency : Can be used to set the i2c bus frequency. If unspecified,
>> +     a default frequency of 60kHz is being used.
> 
> clock-frequency is the standard name for such things.

I was just confused by the fact that unlike a serial port, i2c is a bus itself.

Thanks,
Jochen

WARNING: multiple messages have this Message-ID (diff)
From: Jochen Friedrich <jochen@scram.de>
To: Scott Wood <scottwood@freescale.com>
Cc: "Kernel, Linux" <linux-kernel@vger.kernel.org>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>, Linux I2C <i2c@lm-sensors.org>,
	Jean Delvare <khali@linux-fr.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] [POWERPC] Add i2c pins to dts and board setup
Date: Wed, 21 May 2008 18:17:06 +0200	[thread overview]
Message-ID: <48344B02.7070308@scram.de> (raw)
In-Reply-To: <20080521151003.GA13858@ld0162-tx32.am.freescale.net>

Hi Scott,

>> +   - linux,i2c-index : Can be used to hard code an i2c bus number.
>> +   - linux,i2c-class : Can be used to override the i2c class.
>
> Why do we need this?

There are still a bunch of i2c drivers using the old API (mainly v4l and dvb stuff)
which are slowly being converted by their subsystem maintainers, though.

> It'd be better to just convert any needed old-style drivers than add this
> to the device tree.

Sure. That's why the parameters are only optional. Once all i2c drivers are
converted, these parameters won't be used anymore. Maybe they should be marked
as deprecated.

>> +   - bus-frequency : Can be used to set the i2c bus frequency. If unspecified,
>> +     a default frequency of 60kHz is being used.
> 
> clock-frequency is the standard name for such things.

I was just confused by the fact that unlike a serial port, i2c is a bus itself.

Thanks,
Jochen

  reply	other threads:[~2008-05-21 16:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 10:31 [PATCH] [POWERPC] Add i2c pins to dts and board setup Jochen Friedrich
2008-05-21 10:31 ` Jochen Friedrich
2008-05-21 15:10 ` Scott Wood
2008-05-21 15:10   ` Scott Wood
2008-05-21 16:17   ` Jochen Friedrich [this message]
2008-05-21 16:17     ` Jochen Friedrich
  -- strict thread matches above, loose matches on Subject: below --
2008-07-02 16:06 [PATCH] powerpc: " Jochen Friedrich
2008-07-02 16:14 ` Kumar Gala
2008-05-10 15:50 [PATCH] [POWERPC] " Jochen Friedrich
2008-05-10 15:50 ` Jochen Friedrich
2008-05-13 16:46 ` Scott Wood
2008-05-13 16:46   ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48344B02.7070308@scram.de \
    --to=jochen@scram.de \
    --cc=akpm@linux-foundation.org \
    --cc=avorontsov@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.