From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>,
Vegard Nossum <vegard.nossum@gmail.com>
Cc: linux-kernel@vger.kernel.org, mpm@selenic.com,
lethal@linux-sh.org, dhowells@redhat.com
Subject: Re: [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through
Date: Thu, 22 May 2008 00:15:39 +0300 [thread overview]
Message-ID: <483490FB.70703@cs.helsinki.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0805211412340.17915@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
>> Hmm, where? page_address() already references ->virtual. I suppose
>> CONFIG_SLUB_DEBUG is a no no as well then so do we want to add a
>> CONFIG_KSIZE_DEBUG config option...? (Btw, I removed the BUG_ON() from kfree()
>> as spotted by Vegard Nossum.)
>
> If it has to be then add CONFIG_KSIZE_DEBUG. There are a number of
> debugging techniques (kmem_check?) that should not be compiled in. Maybe
> add a new config option for those. CONFIG_SLUB_ENABLE_EXPENSIVE_DEBUG?
Oh, kmemcheck is a separate config option already and it's *much much*
more expensive than the ksize() checks will ever be so they shouldn't be
bundled together anyway.
Pekka
next prev parent reply other threads:[~2008-05-21 21:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:25 [RFC/PATCH 2/3] SLUB: make ksize() more strict for page allocator pass-through Pekka J Enberg
2008-05-21 18:52 ` Christoph Lameter
2008-05-21 18:56 ` Pekka Enberg
2008-05-21 21:14 ` Christoph Lameter
2008-05-21 21:15 ` Pekka Enberg [this message]
2008-05-21 21:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483490FB.70703@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.