All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Moving sound/* to drivers/ ?
Date: Wed, 21 May 2008 23:58:10 +0200	[thread overview]
Message-ID: <48349AF2.30009@keyaccess.nl> (raw)
In-Reply-To: <alpine.LFD.1.10.0805211431370.3081@woody.linux-foundation.org>

On 21-05-08 23:44, Linus Torvalds wrote:

> So I would personally certainly not mind somebody doing a 
> 
> 	git mv sound drivers/sound
> 	.. edit makefiles and Kconfig files appropriately ..
> 	git commit -a
> 
> and it wouldn't be a problem for git (ie the repository wouldn't grow or 
> anything like that).

I'd personally like the net/ structure more. So subsystem code under 
sound/ and drivers moved to drivers/sound/.

>> Of course, the primary question is whether it's really worth.
>> The obvious drawback is that patches won't be applicable after the
>> move.
> 
> Well, git merging is actually pretty good at this, so you can apply the 
> patches to the old release and then merge it, and it will do the right 
> thing (perhaps not for newly created files, but that's pretty easy to fix 
> up).

And a few symlinks will do wonders as well. I do/did that when I "port" 
patches developped against mainline to the alsa-kernel HG repo. Not a 
problem that way. Apply and rediff to get the new paths.

> Me personally, I've been more irritated by include/asm-xyz vs arch/xyz. It 
> would be so nice if all the arch-specific changes woudl always show up 
> under arch/ (both from a statistics standpoint, and just because then a 
> diffstat really shows arch-specific stuff really obviously, and sorts all 
> the arch-specific stuff together).

And one would not forget to add the include directory to a "git log" or 
"git bisect" path specification...

Rene.

WARNING: multiple messages have this Message-ID (diff)
From: Rene Herman <rene.herman@keyaccess.nl>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] Moving sound/* to drivers/ ?
Date: Wed, 21 May 2008 23:58:10 +0200	[thread overview]
Message-ID: <48349AF2.30009@keyaccess.nl> (raw)
In-Reply-To: <alpine.LFD.1.10.0805211431370.3081@woody.linux-foundation.org>

On 21-05-08 23:44, Linus Torvalds wrote:

> So I would personally certainly not mind somebody doing a 
> 
> 	git mv sound drivers/sound
> 	.. edit makefiles and Kconfig files appropriately ..
> 	git commit -a
> 
> and it wouldn't be a problem for git (ie the repository wouldn't grow or 
> anything like that).

I'd personally like the net/ structure more. So subsystem code under 
sound/ and drivers moved to drivers/sound/.

>> Of course, the primary question is whether it's really worth.
>> The obvious drawback is that patches won't be applicable after the
>> move.
> 
> Well, git merging is actually pretty good at this, so you can apply the 
> patches to the old release and then merge it, and it will do the right 
> thing (perhaps not for newly created files, but that's pretty easy to fix 
> up).

And a few symlinks will do wonders as well. I do/did that when I "port" 
patches developped against mainline to the alsa-kernel HG repo. Not a 
problem that way. Apply and rediff to get the new paths.

> Me personally, I've been more irritated by include/asm-xyz vs arch/xyz. It 
> would be so nice if all the arch-specific changes woudl always show up 
> under arch/ (both from a statistics standpoint, and just because then a 
> diffstat really shows arch-specific stuff really obviously, and sorts all 
> the arch-specific stuff together).

And one would not forget to add the include directory to a "git log" or 
"git bisect" path specification...

Rene.

  parent reply	other threads:[~2008-05-21 21:55 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-21 21:20 Moving sound/* to drivers/ ? Takashi Iwai
2008-05-21 21:20 ` Takashi Iwai
2008-05-21 21:44 ` Linus Torvalds
2008-05-21 21:44   ` Linus Torvalds
2008-05-21 21:54   ` Sam Ravnborg
2008-05-21 21:54     ` Sam Ravnborg
2008-05-21 21:58   ` Rene Herman [this message]
2008-05-21 21:58     ` [alsa-devel] " Rene Herman
2008-05-21 22:08     ` Rene Herman
2008-05-21 23:21   ` Moving include/asm-* [was: Re: Moving sound/* to drivers/ ?] Paul Mackerras
2008-05-21 23:51     ` Linus Torvalds
2008-05-22  0:56       ` Al Viro
2008-05-22  1:20         ` Linus Torvalds
2008-05-22  1:23           ` Moving include/asm-* David Miller
2008-05-22  8:09             ` Andreas Schwab
2008-05-22 16:12               ` David Miller
2008-05-22 16:32                 ` Andreas Schwab
2008-05-22 17:43                   ` David Miller
2008-05-22  1:23           ` Moving include/asm-* [was: Re: Moving sound/* to drivers/ ?] Harvey Harrison
2008-05-22  1:25             ` Moving include/asm-* David Miller
2008-05-22  1:29             ` Moving include/asm-* [was: Re: Moving sound/* to drivers/ ?] Linus Torvalds
2008-05-22  1:36               ` Al Viro
2008-05-22  4:20               ` Jeff Dike
2008-05-22  5:26                 ` Al Viro
2008-05-22 16:27                   ` Jeff Dike
2008-05-22 17:18                   ` Sam Ravnborg
2008-05-22  1:30           ` Al Viro
2008-05-22 22:52             ` Arnd Bergmann
2008-05-21 22:05 ` Moving sound/* to drivers/ ? Timur Tabi
2008-05-21 22:05   ` [alsa-devel] " Timur Tabi
2008-05-21 22:23 ` Adrian Bunk
2008-05-22  8:22   ` Takashi Iwai
2008-05-22  8:22     ` Takashi Iwai
2008-05-21 23:37 ` Jeff Garzik
2008-05-21 23:53   ` Rene Herman
2008-05-21 23:53     ` Rene Herman
2008-05-22  6:26     ` Jaroslav Kysela
2008-05-22  6:26       ` Jaroslav Kysela
2008-05-22  7:12       ` Sam Ravnborg
2008-05-22  7:12         ` Sam Ravnborg
2008-05-22  7:20         ` Jaroslav Kysela
2008-05-22  7:20           ` Jaroslav Kysela
2008-05-22  8:11       ` Rene Herman
2008-05-22  8:11         ` Rene Herman
2008-05-22  8:27     ` Takashi Iwai
2008-05-22  8:27       ` Takashi Iwai
2008-05-22  8:55       ` Jan Engelhardt
2008-05-22 15:04         ` Linus Torvalds
2008-05-22 15:04           ` Linus Torvalds
2008-05-22 15:50           ` Jan Engelhardt
2008-05-22 16:40           ` Rene Herman
2008-05-22 16:40             ` Rene Herman
2008-05-22  9:57       ` Rene Herman
2008-05-22  9:57         ` Rene Herman
2008-05-22 14:22       ` Adrian Bunk
2008-05-22 14:22         ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48349AF2.30009@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.