* [PATCH][TRIVIAL] r8169.c : fix misleading comment
@ 2008-05-21 14:08 Emmanuel Colbus
2008-05-21 18:53 ` Francois Romieu
0 siblings, 1 reply; 3+ messages in thread
From: Emmanuel Colbus @ 2008-05-21 14:08 UTC (permalink / raw)
To: linux-kernel
Calling "PCI base addr 1" something that can actually lie at
PCI_BASE_ADDR_2 is misleading. Patch follows.
signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
---
diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old 2008-05-21 15:20:46.000000000 +0200
+++ drivers/net/r8169.c 2008-05-21 15:22:16.000000000 +0200
@@ -1632,7 +1632,8 @@
if (rc < 0)
goto err_out_disable_2;
- /* make sure PCI base addr 1 is MMIO */
+ /* make sure PCI base addr 1 (or 2, or whatever the second nonzero
+ * pci base addr is) is MMIO */
if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
if (netif_msg_probe(tp)) {
dev_err(&pdev->dev,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment
2008-05-21 14:08 [PATCH][TRIVIAL] r8169.c : fix misleading comment Emmanuel Colbus
@ 2008-05-21 18:53 ` Francois Romieu
2008-05-22 8:08 ` Emmanuel Colbus
0 siblings, 1 reply; 3+ messages in thread
From: Francois Romieu @ 2008-05-21 18:53 UTC (permalink / raw)
To: Emmanuel Colbus; +Cc: linux-kernel
Emmanuel Colbus <emmanuel.colbus@ovh.net> :
> Calling "PCI base addr 1" something that can actually lie at
> PCI_BASE_ADDR_2 is misleading. Patch follows.
>
> signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
I do not approve:
- the patch does not follow the comment style of the driver
- the comment should be removed, not silly augmented
--
Ueimor
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][TRIVIAL] r8169.c : fix misleading comment
2008-05-21 18:53 ` Francois Romieu
@ 2008-05-22 8:08 ` Emmanuel Colbus
0 siblings, 0 replies; 3+ messages in thread
From: Emmanuel Colbus @ 2008-05-22 8:08 UTC (permalink / raw)
To: Francois Romieu; +Cc: linux-kernel
Francois Romieu wrote:
> Emmanuel Colbus <emmanuel.colbus@ovh.net> :
>
>> Calling "PCI base addr 1" something that can actually lie at
>> PCI_BASE_ADDR_2 is misleading. Patch follows.
>>
>> signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
>>
>
> I do not approve:
> - the patch does not follow the comment style of the driver
> - the comment should be removed, not silly augmented
>
>
OK, makes sense. Second version :
This comment is misleading, since the region it refers to can actually
be PCI_BASE_ADDR_2. Remove it.
signed-off-by : emmanuel colbus <emmanuel.colbus@ovh.net>
---
diff -Naur drivers/net/r8169.c.old drivers/net/r8169.c
--- drivers/net/r8169.c.old 2008-05-22 09:55:51.000000000 +0200
+++ drivers/net/r8169.c 2008-05-22 09:55:59.000000000 +0200
@@ -1632,7 +1632,6 @@
if (rc < 0)
goto err_out_disable_2;
- /* make sure PCI base addr 1 is MMIO */
if (!(pci_resource_flags(pdev, region) & IORESOURCE_MEM)) {
if (netif_msg_probe(tp)) {
dev_err(&pdev->dev,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-22 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-21 14:08 [PATCH][TRIVIAL] r8169.c : fix misleading comment Emmanuel Colbus
2008-05-21 18:53 ` Francois Romieu
2008-05-22 8:08 ` Emmanuel Colbus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.