[PATCH 1/2] hamradio/scc: add missing block braces to multi-statement if

[PATCH 1/2] hamradio/scc: add missing block braces to multi-statement if

[Ilpo Järvinen]

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 drivers/net/hamradio/scc.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/hamradio/scc.c b/drivers/net/hamradio/scc.c
index f905159..45ae9d1 100644
--- a/drivers/net/hamradio/scc.c
+++ b/drivers/net/hamradio/scc.c
@@ -1340,9 +1340,10 @@ static unsigned int scc_set_param(struct scc_channel *scc, unsigned int cmd, uns
 		case PARAM_RTS:	
 			if ( !(scc->wreg[R5] & RTS) )
 			{
-				if (arg != TX_OFF)
+				if (arg != TX_OFF) {
 					scc_key_trx(scc, TX_ON);
 					scc_start_tx_timer(scc, t_txdelay, scc->kiss.txdelay);
+				}
 			} else {
 				if (arg == TX_OFF)
 				{
-- 
1.5.2.2

[PATCH 2/2] s2io: add missing block braces to multistatement if statement

[Ilpo Järvinen]

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Cc: Ramkrishna Vepa <ram.vepa@neterion.com>
Cc: Rastapur Santosh <santosh.rastapur@neterion.com>
Cc: Sivakumar Subramani <sivakumar.subramani@neterion.com>
Cc: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
---
 drivers/net/s2io.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 523478e..0f3d230 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -1113,9 +1113,10 @@ static int s2io_on_nec_bridge(struct pci_dev *s2io_pdev)
 	struct pci_dev *tdev = NULL;
 	while ((tdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, tdev)) != NULL) {
 		if (tdev->vendor == NEC_VENID && tdev->device == NEC_DEVID) {
-			if (tdev->bus == s2io_pdev->bus->parent)
+			if (tdev->bus == s2io_pdev->bus->parent) {
 				pci_dev_put(tdev);
 				return 1;
+			}
 		}
 	}
 	return 0;
-- 
1.5.2.2

RE: [PATCH 2/2] s2io: add missing block braces to multistatement if statement

[Ramkrishna Vepa]

Jeff,

Patch looks good. Please accept.

Thanks,
Ram

> -----Original Message-----
> From: Ilpo Järvinen [mailto:ilpo.jarvinen@helsinki.fi]
> Sent: Tuesday, May 13, 2008 4:17 AM
> To: Jeff Garzik
> Cc: netdev@vger.kernel.org; Ilpo Jrvinen; Ramkrishna Vepa; Rastapur
> Santosh; Sivakumar Subramani; Sreenivasa Honnur
> Subject: [PATCH 2/2] s2io: add missing block braces to multistatement if
> statement
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Cc: Ramkrishna Vepa <ram.vepa@neterion.com>
> Cc: Rastapur Santosh <santosh.rastapur@neterion.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@neterion.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
> ---
>  drivers/net/s2io.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
> index 523478e..0f3d230 100644
> --- a/drivers/net/s2io.c
> +++ b/drivers/net/s2io.c
> @@ -1113,9 +1113,10 @@ static int s2io_on_nec_bridge(struct pci_dev
> *s2io_pdev)
>  	struct pci_dev *tdev = NULL;
>  	while ((tdev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, tdev)) !=
> NULL) {
>  		if (tdev->vendor == NEC_VENID && tdev->device == NEC_DEVID) {
> -			if (tdev->bus == s2io_pdev->bus->parent)
> +			if (tdev->bus == s2io_pdev->bus->parent) {
>  				pci_dev_put(tdev);
>  				return 1;
> +			}
>  		}
>  	}
>  	return 0;
> --
> 1.5.2.2

Re: [PATCH 2/2] s2io: add missing block braces to multistatement if statement

[Jeff Garzik]

Ilpo Järvinen wrote:
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> Cc: Ramkrishna Vepa <ram.vepa@neterion.com>
> Cc: Rastapur Santosh <santosh.rastapur@neterion.com>
> Cc: Sivakumar Subramani <sivakumar.subramani@neterion.com>
> Cc: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
> ---
>  drivers/net/s2io.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

applied 1-2