diff for duplicates of <48354A7E.5070105@garzik.org> diff --git a/a/1.txt b/N1/1.txt index bed08c2..237ea55 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ Julia Lawall wrote: > > The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c. > -> if (fep->ops = NULL) { +> if (fep->ops == NULL) { > printk(KERN_ERR DRV_MODULE_NAME > ": %s No matching ops found (%d).\n", > ndev->name, fpi->fs_no); @@ -25,9 +25,9 @@ Julia Lawall wrote: > statement S1,S2,S3; > @@ > -> * if (E = NULL) +> * if (E == NULL) > { -> ... when != if (E = NULL) S1 else S2 +> ... when != if (E == NULL) S1 else S2 > when != E = E1 > * E->f > ... when any diff --git a/a/content_digest b/N1/content_digest index 10374f2..4839cfe 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0Pine.LNX.4.64.0805121537590.3694@ask.diku.dk\0" "From\0Jeff Garzik <jeff@garzik.org>\0" "Subject\0Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference\0" - "Date\0Thu, 22 May 2008 10:27:10 +0000\0" + "Date\0Thu, 22 May 2008 06:27:10 -0400\0" "To\0Julia Lawall <julia@diku.dk>\0" "Cc\0netdev@vger.kernel.org" kernel-janitors@vger.kernel.org @@ -15,7 +15,7 @@ "> \n" "> The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.\n" "> \n" - "> \tif (fep->ops = NULL) {\n" + "> \tif (fep->ops == NULL) {\n" "> \t\tprintk(KERN_ERR DRV_MODULE_NAME\n" "> \t\t \": %s No matching ops found (%d).\\n\",\n" "> \t\t ndev->name, fpi->fs_no);\n" @@ -37,9 +37,9 @@ "> statement S1,S2,S3;\n" "> @@\n" "> \n" - "> * if (E = NULL)\n" + "> * if (E == NULL)\n" "> {\n" - "> ... when != if (E = NULL) S1 else S2\n" + "> ... when != if (E == NULL) S1 else S2\n" "> when != E = E1\n" "> * E->f\n" "> ... when any\n" @@ -52,4 +52,4 @@ "\n" applied -e52aaf02855046b71b018fe12136b315e8b7270183c3255c7ca63ef0f1d19a7d +72bbcc19b89ccfe6ffe42371aa64df55f84b4c04a175e5da0927cdbc80afa4e3
diff --git a/a/1.txt b/N2/1.txt index bed08c2..237ea55 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ Julia Lawall wrote: > > The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c. > -> if (fep->ops = NULL) { +> if (fep->ops == NULL) { > printk(KERN_ERR DRV_MODULE_NAME > ": %s No matching ops found (%d).\n", > ndev->name, fpi->fs_no); @@ -25,9 +25,9 @@ Julia Lawall wrote: > statement S1,S2,S3; > @@ > -> * if (E = NULL) +> * if (E == NULL) > { -> ... when != if (E = NULL) S1 else S2 +> ... when != if (E == NULL) S1 else S2 > when != E = E1 > * E->f > ... when any diff --git a/a/content_digest b/N2/content_digest index 10374f2..e496e17 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,13 +1,14 @@ "ref\0Pine.LNX.4.64.0805121537590.3694@ask.diku.dk\0" "From\0Jeff Garzik <jeff@garzik.org>\0" "Subject\0Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference\0" - "Date\0Thu, 22 May 2008 10:27:10 +0000\0" + "Date\0Thu, 22 May 2008 06:27:10 -0400\0" "To\0Julia Lawall <julia@diku.dk>\0" - "Cc\0netdev@vger.kernel.org" - kernel-janitors@vger.kernel.org - linux-kernel@vger.kernel.org + "Cc\0pantelis.antoniou@gmail.com" + vbordug@ru.mvista.com linuxppc-dev@ozlabs.org - " vbordug@ru.mvista.com\0" + netdev@vger.kernel.org + linux-kernel@vger.kernel.org + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "Julia Lawall wrote:\n" @@ -15,7 +16,7 @@ "> \n" "> The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.\n" "> \n" - "> \tif (fep->ops = NULL) {\n" + "> \tif (fep->ops == NULL) {\n" "> \t\tprintk(KERN_ERR DRV_MODULE_NAME\n" "> \t\t \": %s No matching ops found (%d).\\n\",\n" "> \t\t ndev->name, fpi->fs_no);\n" @@ -37,9 +38,9 @@ "> statement S1,S2,S3;\n" "> @@\n" "> \n" - "> * if (E = NULL)\n" + "> * if (E == NULL)\n" "> {\n" - "> ... when != if (E = NULL) S1 else S2\n" + "> ... when != if (E == NULL) S1 else S2\n" "> when != E = E1\n" "> * E->f\n" "> ... when any\n" @@ -52,4 +53,4 @@ "\n" applied -e52aaf02855046b71b018fe12136b315e8b7270183c3255c7ca63ef0f1d19a7d +bd27ad3679d5f70746280c6f69410ab03910a4d2adaffcaec94db842d983ad64
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.