From: Jeff Garzik <jeff@garzik.org>
To: Julia Lawall <julia@diku.dk>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
vbordug@ru.mvista.com
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Thu, 22 May 2008 10:27:10 +0000 [thread overview]
Message-ID: <48354A7E.5070105@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805121537590.3694@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.
>
> if (fep->ops = NULL) {
> printk(KERN_ERR DRV_MODULE_NAME
> ": %s No matching ops found (%d).\n",
> ndev->name, fpi->fs_no);
> err = -EINVAL;
> goto err;
> }
>
> This code implies that at the point of err, fep->ops can be NULL, so an
> extra test is needed before dereferencing this value.
>
>
> This problem was found using the following semantic match
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression E, E1;
> identifier f;
> statement S1,S2,S3;
> @@
>
> * if (E = NULL)
> {
> ... when != if (E = NULL) S1 else S2
> when != E = E1
> * E->f
> ... when any
> return ...;
> }
> else S3
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Julia Lawall <julia@diku.dk>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
vbordug@ru.mvista.com
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Thu, 22 May 2008 06:27:10 -0400 [thread overview]
Message-ID: <48354A7E.5070105@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805121537590.3694@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.
>
> if (fep->ops == NULL) {
> printk(KERN_ERR DRV_MODULE_NAME
> ": %s No matching ops found (%d).\n",
> ndev->name, fpi->fs_no);
> err = -EINVAL;
> goto err;
> }
>
> This code implies that at the point of err, fep->ops can be NULL, so an
> extra test is needed before dereferencing this value.
>
>
> This problem was found using the following semantic match
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression E, E1;
> identifier f;
> statement S1,S2,S3;
> @@
>
> * if (E == NULL)
> {
> ... when != if (E == NULL) S1 else S2
> when != E = E1
> * E->f
> ... when any
> return ...;
> }
> else S3
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
applied
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Julia Lawall <julia@diku.dk>
Cc: pantelis.antoniou@gmail.com, vbordug@ru.mvista.com,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Thu, 22 May 2008 06:27:10 -0400 [thread overview]
Message-ID: <48354A7E.5070105@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0805121537590.3694@ask.diku.dk>
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.
>
> if (fep->ops == NULL) {
> printk(KERN_ERR DRV_MODULE_NAME
> ": %s No matching ops found (%d).\n",
> ndev->name, fpi->fs_no);
> err = -EINVAL;
> goto err;
> }
>
> This code implies that at the point of err, fep->ops can be NULL, so an
> extra test is needed before dereferencing this value.
>
>
> This problem was found using the following semantic match
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression E, E1;
> identifier f;
> statement S1,S2,S3;
> @@
>
> * if (E == NULL)
> {
> ... when != if (E == NULL) S1 else S2
> when != E = E1
> * E->f
> ... when any
> return ...;
> }
> else S3
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
applied
next prev parent reply other threads:[~2008-05-22 10:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:38 [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Julia Lawall
2008-05-12 13:38 ` Julia Lawall
2008-05-12 15:37 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer Vitaly Bordug
2008-05-12 15:37 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Vitaly Bordug
2008-05-12 15:37 ` Vitaly Bordug
2008-05-12 16:51 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer Francois Romieu
2008-05-12 16:51 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Francois Romieu
2008-05-12 16:51 ` Francois Romieu
2008-05-12 17:22 ` Scott Wood
2008-05-12 17:22 ` Scott Wood
2008-05-12 17:22 ` Scott Wood
2008-05-22 10:27 ` Jeff Garzik [this message]
2008-05-22 10:27 ` Jeff Garzik
2008-05-22 10:27 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48354A7E.5070105@garzik.org \
--to=jeff@garzik.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.