From: Scott Wood <scottwood@freescale.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Julia Lawall <julia@diku.dk>,
vbordug@ru.mvista.com, jgarzik@pobox.com
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Mon, 12 May 2008 17:22:44 +0000 [thread overview]
Message-ID: <48287CE4.9050304@freescale.com> (raw)
In-Reply-To: <20080512165142.GC22190@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Julia Lawall <julia@diku.dk> :
> [...]
>> diff -u -p a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
>> --- a/drivers/net/fs_enet/fs_enet-main.c 2008-04-27 11:41:11.000000000 +0200
>> +++ b/drivers/net/fs_enet/fs_enet-main.c 2008-05-12 09:41:52.000000000 +0200
>> @@ -1093,7 +1093,7 @@ err:
>> if (registered)
>> unregister_netdev(ndev);
>>
>> - if (fep != NULL) {
>> + if (fep && fep->ops) {
>> (*fep->ops->free_bd)(ndev);
>> (*fep->ops->cleanup_data)(ndev);
>> }
>
> Extra cookies for the nice soul who:
> - removes the 'if (registered)' test (it can not happen)
> - uses different error lablels and unrolls the error path. I can not claim
> that the current error path is wrong but it would not hurt if it was more
> trivially balanced.
>
Please note that this code is going away very soon, when arch/ppc dies.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Julia Lawall <julia@diku.dk>,
vbordug@ru.mvista.com, jgarzik@pobox.com
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Mon, 12 May 2008 12:22:44 -0500 [thread overview]
Message-ID: <48287CE4.9050304@freescale.com> (raw)
In-Reply-To: <20080512165142.GC22190@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Julia Lawall <julia@diku.dk> :
> [...]
>> diff -u -p a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
>> --- a/drivers/net/fs_enet/fs_enet-main.c 2008-04-27 11:41:11.000000000 +0200
>> +++ b/drivers/net/fs_enet/fs_enet-main.c 2008-05-12 09:41:52.000000000 +0200
>> @@ -1093,7 +1093,7 @@ err:
>> if (registered)
>> unregister_netdev(ndev);
>>
>> - if (fep != NULL) {
>> + if (fep && fep->ops) {
>> (*fep->ops->free_bd)(ndev);
>> (*fep->ops->cleanup_data)(ndev);
>> }
>
> Extra cookies for the nice soul who:
> - removes the 'if (registered)' test (it can not happen)
> - uses different error lablels and unrolls the error path. I can not claim
> that the current error path is wrong but it would not hurt if it was more
> trivially balanced.
>
Please note that this code is going away very soon, when arch/ppc dies.
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Julia Lawall <julia@diku.dk>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
vbordug@ru.mvista.com, jgarzik@pobox.com
Subject: Re: [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference
Date: Mon, 12 May 2008 12:22:44 -0500 [thread overview]
Message-ID: <48287CE4.9050304@freescale.com> (raw)
In-Reply-To: <20080512165142.GC22190@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> Julia Lawall <julia@diku.dk> :
> [...]
>> diff -u -p a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
>> --- a/drivers/net/fs_enet/fs_enet-main.c 2008-04-27 11:41:11.000000000 +0200
>> +++ b/drivers/net/fs_enet/fs_enet-main.c 2008-05-12 09:41:52.000000000 +0200
>> @@ -1093,7 +1093,7 @@ err:
>> if (registered)
>> unregister_netdev(ndev);
>>
>> - if (fep != NULL) {
>> + if (fep && fep->ops) {
>> (*fep->ops->free_bd)(ndev);
>> (*fep->ops->cleanup_data)(ndev);
>> }
>
> Extra cookies for the nice soul who:
> - removes the 'if (registered)' test (it can not happen)
> - uses different error lablels and unrolls the error path. I can not claim
> that the current error path is wrong but it would not hurt if it was more
> trivially balanced.
>
Please note that this code is going away very soon, when arch/ppc dies.
-Scott
next prev parent reply other threads:[~2008-05-12 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-12 13:38 [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Julia Lawall
2008-05-12 13:38 ` Julia Lawall
2008-05-12 15:37 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer Vitaly Bordug
2008-05-12 15:37 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Vitaly Bordug
2008-05-12 15:37 ` Vitaly Bordug
2008-05-12 16:51 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer Francois Romieu
2008-05-12 16:51 ` [PATCH 4/6] drivers/net/fs_enet: remove null pointer dereference Francois Romieu
2008-05-12 16:51 ` Francois Romieu
2008-05-12 17:22 ` Scott Wood [this message]
2008-05-12 17:22 ` Scott Wood
2008-05-12 17:22 ` Scott Wood
2008-05-22 10:27 ` Jeff Garzik
2008-05-22 10:27 ` Jeff Garzik
2008-05-22 10:27 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48287CE4.9050304@freescale.com \
--to=scottwood@freescale.com \
--cc=jgarzik@pobox.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.